Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gov)!: finalize collections migration #16268

Merged
merged 18 commits into from
May 26, 2023

Conversation

testinginprod
Copy link
Contributor

@testinginprod testinginprod commented May 24, 2023

Description

Closes: #16267


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@testinginprod testinginprod marked this pull request as ready for review May 24, 2023 09:00
@testinginprod testinginprod requested a review from a team as a code owner May 24, 2023 09:00
@testinginprod testinginprod changed the title refactor!(gov): finalize collections migrations refactor(gov)!: finalize collections migrations May 24, 2023
@testinginprod testinginprod changed the title refactor(gov)!: finalize collections migrations refactor(gov)!: finalize collections migration May 24, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one tiny nit.

@@ -118,27 +111,22 @@ func (suite *KeeperTestSuite) TestDeleteProposalInVotingPeriod() {
suite.Require().NoError(err)
suite.Require().Nil(proposal.VotingStartTime)

suite.govKeeper.ActivateVotingPeriod(suite.ctx, proposal)
require.NoError(suite.T(), suite.govKeeper.ActivateVotingPeriod(suite.ctx, proposal))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, we should use suite.Require() for conssitency.

@testinginprod testinginprod added this pull request to the merge queue May 26, 2023
Merged via the queue into main with commit b62a28a May 26, 2023
@testinginprod testinginprod deleted the tip/gov/finalize-collections branch May 26, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor!(gov): Finalize migration to collections
2 participants