Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: snapshotter's failure is not propogated #16588

Merged
merged 5 commits into from
Jun 17, 2023
Merged

fix: snapshotter's failure is not propogated #16588

merged 5 commits into from
Jun 17, 2023

Commits on Jun 16, 2023

  1. fix: snapshotter failure is not propogated 

    Solution:
- create a dummy pipe to propogate the error
- add unit tests to verify it
    @yihuang
    yihuang committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    8893c8c View commit details
    Browse the repository at this point in the history

  2. Update store/CHANGELOG.md

    @yihuang
    yihuang authored Jun 16, 2023
    Configuration menu
    Copy the full SHA
    3211011 View commit details
    Browse the repository at this point in the history

  3. cleanup

    @yihuang
    yihuang committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    7c002bc View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. fix lint

    @yihuang
    yihuang committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    e3331a7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into snapshot-error

    @yihuang
    yihuang authored Jun 17, 2023
    Configuration menu
    Copy the full SHA
    b9ecdb3 View commit details
    Browse the repository at this point in the history