Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/consensus): Add missing ABCI consensus param in MsgUpdateParams #16713

Merged
merged 7 commits into from
Jun 28, 2023

Conversation

facundomedica
Copy link
Member

Description

During my audit of baseapp I found that it was not possible to enable vote extensions through a gov proposal. This should address that issue.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@facundomedica facundomedica marked this pull request as ready for review June 27, 2023 10:38
@facundomedica facundomedica requested a review from a team as a code owner June 27, 2023 10:38
@github-prbot github-prbot requested review from a team, alexanderbez and likhita-809 and removed request for a team June 27, 2023 10:38
@facundomedica facundomedica added backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release T: Audit labels Jun 27, 2023
@facundomedica facundomedica mentioned this pull request Jun 27, 2023
19 tasks
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, we should document that this field should be changed only when preparing for enabling VE after a coordinated upgrade. this would happen within the upgrade most likely. @alexanderbez what do you think of limiting this to not be modifiable via these calls

@facundomedica
Copy link
Member Author

facundomedica commented Jun 27, 2023

utACK, we should document that this field should be changed only when preparing for enabling VE after a coordinated upgrade. this would happen within the upgrade most likely. @alexanderbez what do you think of limiting this to not be modifiable via these calls

I've added the following in UPGRADING.md in another PR: https://github.com/cosmos/cosmos-sdk/pull/16596/files#diff-f411a5009131db5a6c7242b49ca78488f2d274ef9e5e5f4de9262a42108a5386R32-R43

I'll probably add more detail, especially for: - A governance proposal that changes the consensus param.. I'll write there that we need to make sure this happens after an upgrade that adds the functionality

EDIT: updated here: https://github.com/cosmos/cosmos-sdk/blob/7b5cbb71d3b4dc3c8b5aaaf89201ea9085fd14a7/UPGRADING.md#enable-vote-extensions

@alexanderbez
Copy link
Contributor

alexanderbez commented Jun 27, 2023

@tac0turtle yes, I agree. @facundomedica changes make sense to me!

VE will need to be enabled via an explicit software upgrade.

@facundomedica facundomedica enabled auto-merge June 28, 2023 08:31
@facundomedica facundomedica added this pull request to the merge queue Jun 28, 2023
Merged via the queue into main with commit 6d7b64e Jun 28, 2023
@facundomedica facundomedica deleted the facu/fix-gov-consensusparams branch June 28, 2023 19:34
mergify bot pushed a commit that referenced this pull request Jun 28, 2023
…#16713)

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
(cherry picked from commit 6d7b64e)

# Conflicts:
#	CHANGELOG.md
julienrbrt added a commit that referenced this pull request Jun 28, 2023
… (backport #16713) (#16745)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/consensus T: Audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants