-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(x/consensus): Add missing ABCI consensus param in MsgUpdateParams #16713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK, we should document that this field should be changed only when preparing for enabling VE after a coordinated upgrade. this would happen within the upgrade most likely. @alexanderbez what do you think of limiting this to not be modifiable via these calls
I've added the following in UPGRADING.md in another PR: https://github.com/cosmos/cosmos-sdk/pull/16596/files#diff-f411a5009131db5a6c7242b49ca78488f2d274ef9e5e5f4de9262a42108a5386R32-R43 I'll probably add more detail, especially for: EDIT: updated here: https://github.com/cosmos/cosmos-sdk/blob/7b5cbb71d3b4dc3c8b5aaaf89201ea9085fd14a7/UPGRADING.md#enable-vote-extensions |
@tac0turtle yes, I agree. @facundomedica changes make sense to me! VE will need to be enabled via an explicit software upgrade. |
Description
During my audit of baseapp I found that it was not possible to enable vote extensions through a gov proposal. This should address that issue.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change