Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vesting)!: improve validate functions and return error in constructor #16741

Merged
merged 6 commits into from
Jun 29, 2023

Conversation

julienrbrt
Copy link
Member

Description

ref: #16733 (comment)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jun 28, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner June 28, 2023 15:40
@github-prbot github-prbot requested review from a team, JeancarloBarrios and tac0turtle and removed request for a team June 28, 2023 15:40
@github-actions github-actions bot added C:Simulations C:x/genutil genutil module issues labels Jun 28, 2023
@julienrbrt julienrbrt changed the title feat(vesting)!: improve validate functions and return error in constructor refactor(vesting)!: improve validate functions and return error in constructor Jun 28, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Jun 29, 2023
Merged via the queue into main with commit adc7451 Jun 29, 2023
@julienrbrt julienrbrt deleted the julien/impr-vesting branch June 29, 2023 10:53
mergify bot pushed a commit that referenced this pull request Jun 29, 2023
…nstructor (#16741)

(cherry picked from commit adc7451)

# Conflicts:
#	CHANGELOG.md
julienrbrt added a commit that referenced this pull request Jun 29, 2023
…nstructor (backport #16741) (#16763)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@alexanderbez
Copy link
Contributor

Thanks for doing this @julienrbrt 🙏

@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:Simulations C:x/auth C:x/bank C:x/genutil genutil module issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants