Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: simplify AppModuleBasic interface for CLI #16890

Merged
merged 14 commits into from
Jul 10, 2023
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jul 9, 2023

Description

ref: #16754 (comment)

  • Add docs in SDK docs about defining CLI (or the fallback to AutoCLI)
  • Mention in UPGRADING.md that those functions can be deleted

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 9, 2023
if cmd := b.GetTxCmd(); cmd != nil {
rootTxCmd.AddCommand(cmd)
if mod, ok := b.(interface {
GetTxCmd() *cobra.Command
Copy link
Member Author

@julienrbrt julienrbrt Jul 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, this replicates the behavior from the Core API Adapter:

func (c coreAppModuleBasicAdaptor) GetQueryCmd() *cobra.Command {
if mod, ok := c.module.(interface {
GetQueryCmd() *cobra.Command
}); ok {
return mod.GetQueryCmd()
}
return nil
}

@julienrbrt julienrbrt marked this pull request as ready for review July 10, 2023 09:52
@julienrbrt julienrbrt requested a review from a team as a code owner July 10, 2023 09:52
@github-actions github-actions bot added C:Rosetta Issues and PR related to Rosetta C:Confix Issues and PR related to Confix labels Jul 10, 2023
@github-prbot github-prbot requested review from a team, tac0turtle and samricotta and removed request for a team July 10, 2023 09:52
@github-actions

This comment has been minimized.

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

x/mint/module.go Outdated
Comment on lines 83 to 85
// GetTxCmd returns no root tx command for the mint module.
func (AppModuleBasic) GetTxCmd() *cobra.Command { return nil }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove as well?

@julienrbrt julienrbrt enabled auto-merge July 10, 2023 12:58
@julienrbrt julienrbrt disabled auto-merge July 10, 2023 13:12
@julienrbrt julienrbrt enabled auto-merge July 10, 2023 13:18
@julienrbrt julienrbrt added this pull request to the merge queue Jul 10, 2023
Merged via the queue into main with commit f3e4697 Jul 10, 2023
@julienrbrt julienrbrt deleted the julien/amb-cli branch July 10, 2023 13:38
mergify bot pushed a commit that referenced this pull request Jul 10, 2023
(cherry picked from commit f3e4697)

# Conflicts:
#	CHANGELOG.md
#	x/evidence/go.mod
#	x/evidence/go.sum
#	x/nft/go.mod
#	x/nft/go.sum
julienrbrt added a commit that referenced this pull request Jul 10, 2023
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:Confix Issues and PR related to Confix C:Rosetta Issues and PR related to Rosetta C:x/auth C:x/bank C:x/consensus C:x/crisis C:x/distribution distribution module related C:x/evidence C:x/feegrant C:x/genutil genutil module issues C:x/mint C:x/nft C:x/params C:x/staking Type: Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants