Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client/v2): stringify bytes cosmos.Dec #16985

Merged
merged 11 commits into from
Sep 13, 2023
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jul 13, 2023

Description

Found while working on #16659.

Currently, we with client/v2 we get the following:

params:
  downtime_jail_duration: 600s
  min_signed_per_window: NTAwMDAwMDAwMDAwMDAwMDAw
  signed_blocks_window: "100"
  slash_fraction_double_sign: NTAwMDAwMDAwMDAwMDAwMDA=
  slash_fraction_downtime: MTAwMDAwMDAwMDAwMDAwMDA=

It would be better if this showed the corresponding string instead (like in gRPC: https://v050.simapp.zone:1317/cosmos/slashing/v1beta1/params)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt changed the base branch from julien/support-consensus-address to main July 13, 2023 12:09
@julienrbrt julienrbrt marked this pull request as ready for review September 11, 2023 21:44
@julienrbrt julienrbrt requested a review from a team as a code owner September 11, 2023 21:44
@github-actions
Copy link
Contributor

@julienrbrt your pull request is missing a changelog!

@julienrbrt
Copy link
Member Author

Can be merged once #17681 is merged.

Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any way to add tests to check that we're getting desired output?

@julienrbrt
Copy link
Member Author

is there any way to add tests to check that we're getting desired output?

You can try for now locally, I will add a test here: #17707, as duration is a message, and I need to fix the message binder to test this nicely. However it is really hacky.

Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@julienrbrt julienrbrt added this pull request to the merge queue Sep 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 13, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Sep 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 13, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Sep 13, 2023
Merged via the queue into main with commit 2f4e109 Sep 13, 2023
49 checks passed
@julienrbrt julienrbrt deleted the julien/support-cosmos-dec branch September 13, 2023 13:18
mergify bot pushed a commit that referenced this pull request Sep 13, 2023
(cherry picked from commit 2f4e109)

# Conflicts:
#	client/v2/go.mod
#	client/v2/go.sum
#	simapp/go.mod
#	simapp/go.sum
#	simapp/gomod2nix.toml
#	tests/go.mod
#	tests/go.sum
#	tests/starship/tests/go.mod
#	tests/starship/tests/go.sum
julienrbrt added a commit that referenced this pull request Sep 13, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants