-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client/v2): stringify bytes cosmos.Dec
#16985
Conversation
f50878d
to
673270d
Compare
ce9c2f9
to
3de7bba
Compare
fe1a192
to
2b76e18
Compare
@julienrbrt your pull request is missing a changelog! |
Can be merged once #17681 is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any way to add tests to check that we're getting desired output?
You can try for now locally, I will add a test here: #17707, as duration is a message, and I need to fix the message binder to test this nicely. However it is really hacky. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck
(cherry picked from commit 2f4e109) # Conflicts: # client/v2/go.mod # client/v2/go.sum # simapp/go.mod # simapp/go.sum # simapp/gomod2nix.toml # tests/go.mod # tests/go.sum # tests/starship/tests/go.mod # tests/starship/tests/go.sum
Co-authored-by: Julien Robert <julien@rbrt.fr>
Description
Found while working on #16659.
Currently, we with client/v2 we get the following:
It would be better if this showed the corresponding string instead (like in gRPC: https://v050.simapp.zone:1317/cosmos/slashing/v1beta1/params)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change