Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/group): rename group's legacy ORM error codespace to prevent co… #17146

Merged

Conversation

technicallyty
Copy link
Contributor

…llisions with new ORM codespace

Description

Closes: N/A

  • Renames x/group's legacy ORM error codespace, as it collides with the new ORM's error codespace. Using both new ORM and x/group would cause a duplicate registration of "orm", causing the app to panic.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@technicallyty technicallyty requested a review from a team as a code owner July 26, 2023 16:08
@github-prbot github-prbot requested a review from a team July 26, 2023 16:09
@github-prbot github-prbot requested review from tac0turtle and julienrbrt and removed request for a team July 26, 2023 16:09
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 26, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@julienrbrt julienrbrt enabled auto-merge July 26, 2023 16:54
@julienrbrt julienrbrt added this pull request to the merge queue Jul 26, 2023
Merged via the queue into cosmos:main with commit 026073b Jul 26, 2023
mergify bot pushed a commit that referenced this pull request Jul 26, 2023
#17146)

(cherry picked from commit 026073b)

# Conflicts:
#	CHANGELOG.md
julienrbrt pushed a commit that referenced this pull request Jul 26, 2023
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/group
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants