Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/staking): DelegationsByValidator migrations #17154

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jul 27, 2023

Description

we have found a bug earlier that we are using the same prefix key for UnbondingIDKey & DelegationByValIndexKey ref and that's been addressed in #16176, but we missed to update the key in staking migrations.

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp requested a review from julienrbrt July 27, 2023 07:16
@atheeshp atheeshp added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 27, 2023
@atheeshp atheeshp changed the title fix(x/staking): delegation by validator migrations fix(x/staking): DelegationByValidator migrations Jul 27, 2023
@atheeshp atheeshp changed the title fix(x/staking): DelegationByValidator migrations fix(x/staking): DelegationsByValidator migrations Jul 27, 2023
@atheeshp atheeshp marked this pull request as ready for review July 27, 2023 07:33
@atheeshp atheeshp requested a review from a team as a code owner July 27, 2023 07:33
@github-actions
Copy link
Contributor

@atheeshp your pull request is missing a changelog!

Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@julienrbrt julienrbrt added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit 9a42a3e Jul 27, 2023
@julienrbrt julienrbrt deleted the ap/fix-stkaing-migrations branch July 27, 2023 08:15
mergify bot pushed a commit that referenced this pull request Jul 27, 2023
julienrbrt pushed a commit that referenced this pull request Jul 27, 2023
…#17156)

Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants