-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(x/staking): DelegationsByValidator
migrations
#17154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atheeshp
added
the
backport/v0.50.x
PR scheduled for inclusion in the v0.50's next stable release
label
Jul 27, 2023
atheeshp
changed the title
fix(x/staking): delegation by validator migrations
fix(x/staking): Jul 27, 2023
DelegationByValidator
migrations
atheeshp
changed the title
fix(x/staking):
fix(x/staking): Jul 27, 2023
DelegationByValidator
migrationsDelegationsByValidator
migrations
@atheeshp your pull request is missing a changelog! |
likhita-809
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
julienrbrt
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find!
mergify bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
(cherry picked from commit 9a42a3e)
julienrbrt
pushed a commit
that referenced
this pull request
Jul 27, 2023
…#17156) Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we have found a bug earlier that we are using the same prefix key for
UnbondingIDKey
&DelegationByValIndexKey
ref and that's been addressed in #16176, but we missed to update the key in staking migrations.Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change