Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): remove duplicate --home flag #17215

Merged
merged 7 commits into from
Aug 1, 2023
Merged

refactor(cli): remove duplicate --home flag #17215

merged 7 commits into from
Aug 1, 2023

Conversation

zakir-code
Copy link
Contributor

Description

Ref: #17197

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@zakir-code zakir-code requested a review from a team as a code owner July 31, 2023 10:55
@github-prbot github-prbot requested review from a team, alexanderbez and likhita-809 and removed request for a team July 31, 2023 10:55
@github-actions github-actions bot added C:CLI C:x/genutil genutil module issues labels Jul 31, 2023
@julienrbrt julienrbrt self-assigned this Jul 31, 2023
@julienrbrt julienrbrt self-requested a review July 31, 2023 10:57
julienrbrt
julienrbrt reviewed Jul 31, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm! We need API breaking changes changelog entries.

client/pruning/main.go Outdated Show resolved Hide resolved
@julienrbrt
Copy link
Member

Could you fix the e2e tests?

odeke-em
odeke-em requested changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change @zakir-code! Just some typo in a command name that needs to be fixed.

server/rollback.go Show resolved Hide resolved
server/util_test.go Outdated Show resolved Hide resolved
@zakir-code
Copy link
Contributor Author

@julienrbrt I have fixed the e2e tests. Please review the changes in the latest commit.

julienrbrt
julienrbrt approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK! Two nits

CHANGELOG.md Outdated Show resolved Hide resolved
server/rollback.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we modify fmt.Printf("Rolled back state to height %d and hash %X", height, hash) to fmt.Printf("Rolled back state to height %d and hash %X\n", height, hash) (add a new line)

@julienrbrt julienrbrt requested a review from odeke-em August 1, 2023 08:58
@julienrbrt
Copy link
Member

julienrbrt commented Aug 1, 2023 •
edited
Loading

Not going to backport this to v0.50.x to start limiting the breaking changes in that release, given that consumers already started to integrate with our beta. This will get into v0.51!

odeke-em
odeke-em approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @zakir-code! Thanks for the review @julienrbrt! LGTM after @julienrbrt's code review suggestions.

@julienrbrt julienrbrt added this pull request to the merge queue Aug 1, 2023
Merged via the queue into cosmos:main with commit c36c860 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@odeke-em odeke-em odeke-em approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees

@julienrbrt julienrbrt

Labels
C:CLI C:x/genutil genutil module issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zakir-code @julienrbrt @odeke-em