Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/staking): migrate RedelegationByValSrcIndexKey key to collections #17332

Merged
merged 37 commits into from
Aug 22, 2023

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Aug 9, 2023

Description

Closes: #16382


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp changed the title refactor (x/staking): migrate RedelegationByValSrcIndexKey key to collections refactor(x/staking): migrate RedelegationByValSrcIndexKey key to collections Aug 9, 2023
Base automatically changed from ap/redelegation-key-to-collections to main August 17, 2023 10:34
@atheeshp atheeshp marked this pull request as ready for review August 17, 2023 11:54
@atheeshp atheeshp requested a review from a team as a code owner August 17, 2023 11:54
x/staking/keeper/keeper.go Outdated Show resolved Hide resolved
x/staking/keeper/keeper.go Outdated Show resolved Hide resolved
@kocubinski
Copy link
Member

Ideally I think the state consistency hash tests should be committed in a prior PR asserting state on the pre-collections code path, but I'm not going to block here.

@atheeshp atheeshp added this pull request to the merge queue Aug 22, 2023
Merged via the queue into main with commit 222d28e Aug 22, 2023
46 of 48 checks passed
@atheeshp atheeshp deleted the ap/red-from-val-src-to-coll branch August 22, 2023 07:02
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(staking): move RedelegationByValSrcIndex to use collections
4 participants