Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump to Go 1.21 #17333

Merged
merged 9 commits into from
Aug 18, 2023
Merged

build: bump to Go 1.21 #17333

merged 9 commits into from
Aug 18, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 9, 2023 •
edited
Loading

Description

Bump to Go 1.21.

Purposely not bumping all packages.

The following packages have been bumped (in CI and go.mod):

  • SDK
  • Collections
  • Simapp / Simapp tests
  • Tools
  • Standalone modules (x/tx)

The rationale of not bumping everything is to not force everyone to upgrade when depending on log or math, api, ... packages, and using it in v0.4x.x chains, by mistakenly adding a Go 1.21 only feature. In short, any module that we tag from main, except collections, used in v0.4x.x chains, stay on Go 1.20 for now (in CI and go.mod).

  • Introduce Go matrix in the build pipeline when keeping support for Go 1.20 for some modules.

We need to decide if we go with Go 1.21 for v0.50 for the SDK itself. Adding backport label.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat mentioned this pull request Aug 11, 2023
Merged
@julienrbrt julienrbrt added the S:blocked Status: Blocked label Aug 11, 2023
@julienrbrt julienrbrt marked this pull request as ready for review August 11, 2023 11:35
@julienrbrt julienrbrt requested a review from a team as a code owner August 11, 2023 11:35
@github-prbot github-prbot requested review from a team, tac0turtle and samricotta and removed request for a team August 11, 2023 11:35
julienrbrt
julienrbrt commented Aug 11, 2023
View reviewed changes
flake.nix
@@ -44,7 +44,7 @@
default = simd;
simd = with pkgs; mkShell {
buildInputs = [
go_1_20 # Use Go 1.20 version
go_1_21 # Use Go 1.21 version
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are blocked on this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NixOS/nixpkgs#246935

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway to unblock this or are we going to be stuck like this going forward for future releases? Anyway we can merge this for now since the rocksdb stuff isnt needed right now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can skip the build step and create an issue to re-enable it if that's what we want 👍🏾

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly thinking since this is a blocker for the rc as well. Lets disable it and create an issue

Copy link
Member Author

@julienrbrt julienrbrt Aug 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! will do -> #17437

tac0turtle
tac0turtle reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think its worth doing this for 0.50. collections will use it anyways

@julienrbrt
Copy link
Member Author

julienrbrt commented Aug 14, 2023 •
edited
Loading

i think its worth doing this for 0.50. collections will use it anyways

Okay, then we can bump all x/<...> modules as well (including x/tx). I'll add a backport flag to v0.50.

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Aug 14, 2023
@julienrbrt julienrbrt removed the S:blocked Status: Blocked label Aug 18, 2023
@julienrbrt julienrbrt enabled auto-merge August 18, 2023 09:24
@julienrbrt julienrbrt added this pull request to the merge queue Aug 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 18, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit f0030e0 Aug 18, 2023
@julienrbrt julienrbrt deleted the julien/bump-go branch August 18, 2023 10:01
mergify bot pushed a commit that referenced this pull request Aug 18, 2023
@julienrbrt @mergify
build: bump to Go 1.21 (#17333)
ec525f3 
(cherry picked from commit f0030e0)

# Conflicts:
#	.github/workflows/sims-050.yml
#	.github/workflows/starship-tests.yml
#	collections/go.sum
#	contrib/devtools/Dockerfile
#	flake.nix
#	tests/starship/tests/go.mod
#	tests/starship/tests/go.sum
@mergify mergify bot mentioned this pull request Aug 18, 2023
Merged
julienrbrt added a commit that referenced this pull request Aug 18, 2023
@mergify @julienrbrt
build: bump to Go 1.21 (backport #17333) (#17442)
c402c51 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihuang yihuang yihuang left review comments

@tac0turtle tac0turtle tac0turtle approved these changes

@samricotta samricotta Awaiting requested review from samricotta

Assignees

@alexanderbez alexanderbez

@tac0turtle tac0turtle

Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:collections C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:x/circuit C:x/evidence C:x/feegrant C:x/nft C:x/tx C:x/upgrade Type: Build Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julienrbrt @yihuang @tac0turtle @alexanderbez