Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove collections.ErrInvalidIterator when unecessary #17367

Merged
merged 6 commits into from
Aug 17, 2023

Conversation

julienrbrt
Copy link
Member

Description

Target v0.50 branch.

ref: #17364


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@@ -4,7 +4,7 @@ module github.com/cosmos/cosmos-sdk

require (
cosmossdk.io/api v0.7.0
cosmossdk.io/collections v0.3.0
cosmossdk.io/collections v0.3.1-0.20230808102719-f04fefdc7a68
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@testinginprod, it would be great to get a new version before v0.50 final.
I remember you said you were waiting for something last time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for go 1.21, this has improvements on type inference that should make certain things in collections better, this will cause some breaking changes on collections.

unfortunately, I'm not sure if this will happen before we cut v0.50 final.

when there's intention to cut v0.50 final let me know, and I'll cut collections.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@testinginprod would you want to create a branch with go 1.21 changes to collections that way once we merge jullians pr we can merge yours and get it into 0.50

@julienrbrt julienrbrt marked this pull request as ready for review August 11, 2023 11:54
@julienrbrt julienrbrt requested a review from a team as a code owner August 11, 2023 11:54
@julienrbrt julienrbrt mentioned this pull request Aug 14, 2023
3 tasks
@julienrbrt julienrbrt enabled auto-merge (squash) August 16, 2023 14:00
@julienrbrt julienrbrt merged commit e19fb38 into release/v0.50.x Aug 17, 2023
48 of 49 checks passed
@julienrbrt julienrbrt deleted the julien/errinvalidit-050 branch August 17, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants