Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: genesis on migrations #17679

Merged
merged 3 commits into from
Sep 11, 2023
Merged

fix: genesis on migrations #17679

merged 3 commits into from
Sep 11, 2023

Conversation

tac0turtle
Copy link
Member

Description

reported by ibc that migrations were returning nil when passing using hasABCIGenesis as module1 would have been nil


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Sep 11, 2023
@@ -699,7 +699,7 @@ func (m Manager) RunMigrations(ctx context.Context, cfg Configurator, fromVM Ver
module1.InitGenesis(sdkCtx, c.cdc, module1.DefaultGenesis(c.cdc))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a one-liner for the if condition, so that module1 variable is available only in the if branch.
Possibly rename them both to module as well instead of module1 / module2.

@chatton chatton mentioned this pull request Sep 11, 2023
9 tasks
@tac0turtle tac0turtle marked this pull request as ready for review September 11, 2023 17:31
@tac0turtle tac0turtle requested a review from a team as a code owner September 11, 2023 17:31
@tac0turtle
Copy link
Member Author

opening this to unblock ibc but we should write a test case for this

@tac0turtle tac0turtle added this pull request to the merge queue Sep 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2023
@tac0turtle tac0turtle added this pull request to the merge queue Sep 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2023
@tac0turtle tac0turtle added this pull request to the merge queue Sep 11, 2023
Merged via the queue into main with commit 5eaa7b8 Sep 11, 2023
42 of 47 checks passed
@tac0turtle tac0turtle deleted the marko/fix_genesis branch September 11, 2023 18:26
mergify bot pushed a commit that referenced this pull request Sep 11, 2023
(cherry picked from commit 5eaa7b8)
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants