-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: genesis on migrations #17679
Merged
Merged
fix: genesis on migrations #17679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
added
the
backport/v0.50.x
PR scheduled for inclusion in the v0.50's next stable release
label
Sep 11, 2023
damiannolan
approved these changes
Sep 11, 2023
julienrbrt
approved these changes
Sep 11, 2023
types/module/module.go
Outdated
@@ -699,7 +699,7 @@ func (m Manager) RunMigrations(ctx context.Context, cfg Configurator, fromVM Ver | |||
module1.InitGenesis(sdkCtx, c.cdc, module1.DefaultGenesis(c.cdc)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a one-liner for the if condition, so that module1 variable is available only in the if
branch.
Possibly rename them both to module as well instead of module1 / module2.
9 tasks
opening this to unblock ibc but we should write a test case for this |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 11, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 11, 2023
(cherry picked from commit 5eaa7b8)
julienrbrt
pushed a commit
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reported by ibc that migrations were returning nil when passing using hasABCIGenesis as module1 would have been nil
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change