Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ConsensusParams in BaseApp #1775

Closed
wants to merge 2 commits into from

Conversation

mossid
Copy link
Contributor

@mossid mossid commented Jul 19, 2018

  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Closes: #1007

@mossid mossid changed the title ConsensusParams in BaseApp WIP: ConsensusParams in BaseApp Jul 19, 2018
@mossid mossid added the wip label Jul 19, 2018
@mossid
Copy link
Contributor Author

mossid commented Jul 19, 2018

  1. Modules can change the consensus parameter by either setting on global paramstore or return consensus params update in endblocker
  2. Paramstore now takes transient store key for the modified values

Depending on: #1481

@mossid mossid force-pushed the joon/1007-baseapp-consensusparams branch from 501c1d9 to 704846d Compare July 20, 2018 00:04
@codecov
Copy link

codecov bot commented Jul 20, 2018

Codecov Report

Merging #1775 into develop will increase coverage by 1.43%.
The diff coverage is 72.88%.

@@             Coverage Diff             @@
##           develop    #1775      +/-   ##
===========================================
+ Coverage    62.77%   64.21%   +1.43%     
===========================================
  Files          122      116       -6     
  Lines         7125     6869     -256     
===========================================
- Hits          4473     4411      -62     
+ Misses        2390     2203     -187     
+ Partials       262      255       -7

@mossid mossid force-pushed the joon/1007-baseapp-consensusparams branch from 704846d to 55cc145 Compare July 20, 2018 01:48
@mossid mossid force-pushed the joon/1007-baseapp-consensusparams branch from 55cc145 to 5309c84 Compare July 20, 2018 02:32
move gasconfig to types, make GetKVStoreWithGas take GasConfig

fix lint

modify transientstore

in progress

add test for transientstore

fix errors

fix test

fix errors and lint

last fix

in progress

move transient to KVStore

fix syntax errors

finalize rebase

remove NewMemDBStoreAdapter for lint

apply requests

apply requests

apply requests

add CHANGELOG

add tests

fix getter

in progress

finalize rebase

fix lint

partially apply requests

assert -> require

apply requests

fix test

Changelog => Pending

add TransientStoreKey

fix lint
@mossid mossid force-pushed the joon/1007-baseapp-consensusparams branch from 5309c84 to 40bda9a Compare July 20, 2018 04:14
mossid added a commit that referenced this pull request Jul 20, 2018
add endblocker in params

in progress

fix errors

fix gaiadebug/hack.go

finalize rebase to transientstore branch

fix error
add endblocker in params

in progress

fix errors

fix gaiadebug/hack.go

finalize rebase to transientstore branch

fix error

fix lint
@mossid mossid force-pushed the joon/1007-baseapp-consensusparams branch from 40bda9a to 8fc09c8 Compare July 20, 2018 23:28
@mossid
Copy link
Contributor Author

mossid commented Jul 23, 2018

Merged into #1772

@mossid mossid closed this Jul 23, 2018
@mossid mossid deleted the joon/1007-baseapp-consensusparams branch July 23, 2018 23:35
mossid added a commit that referenced this pull request Jul 23, 2018
add InitGenesis

fix lint

add immutablestore

Merge pull request #1775: ConsensusParams in BaseApp

add endblocker in params

in progress

fix errors

fix gaiadebug/hack.go

finalize rebase to transientstore branch

fix error

fix lint

finalize merging
mossid added a commit that referenced this pull request Jul 25, 2018
add InitGenesis

fix lint

add immutablestore

Merge pull request #1775: ConsensusParams in BaseApp

add endblocker in params

in progress

fix errors

fix gaiadebug/hack.go

finalize rebase to transientstore branch

fix error

fix lint

finalize merging

fix synerror

in progress

in progress

add gasconfig in params, restructure
mossid added a commit that referenced this pull request Jul 27, 2018
add InitGenesis

fix lint

add immutablestore

Merge pull request #1775: ConsensusParams in BaseApp

add endblocker in params

in progress

fix errors

fix gaiadebug/hack.go

finalize rebase to transientstore branch

fix error

fix lint

finalize merging

fix synerror

in progress

in progress

add gasconfig in params, restructure

fix errors

add tests
mossid added a commit that referenced this pull request Aug 3, 2018
add InitGenesis

fix lint

add immutablestore

Merge pull request #1775: ConsensusParams in BaseApp

add endblocker in params

in progress

fix errors

fix gaiadebug/hack.go

finalize rebase to transientstore branch

fix error

fix lint

finalize merging

fix synerror

in progress

in progress

add gasconfig in params, restructure

fix errors

add tests
mossid added a commit that referenced this pull request Aug 14, 2018
add InitGenesis

fix lint

add immutablestore

Merge pull request #1775: ConsensusParams in BaseApp

add endblocker in params

in progress

fix errors

fix gaiadebug/hack.go

finalize rebase to transientstore branch

fix error

fix lint

finalize merging

fix synerror

in progress

in progress

add gasconfig in params, restructure

fix errors

add tests
mossid added a commit that referenced this pull request Aug 17, 2018
add InitGenesis

fix lint

add immutablestore

Merge pull request #1775: ConsensusParams in BaseApp

add endblocker in params

in progress

fix errors

fix gaiadebug/hack.go

finalize rebase to transientstore branch

fix error

fix lint

finalize merging

fix synerror

in progress

in progress

add gasconfig in params, restructure

fix errors

add tests
mossid added a commit that referenced this pull request Aug 25, 2018
add InitGenesis

fix lint

add immutablestore

Merge pull request #1775: ConsensusParams in BaseApp

add endblocker in params

in progress

fix errors

fix gaiadebug/hack.go

finalize rebase to transientstore branch

fix error

fix lint

finalize merging

fix synerror

in progress

in progress

add gasconfig in params, restructure

fix errors

add tests
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
* add feegrant module test

* text spend limit

* check if the bob balance is ok

* add comment docs and flags for `execFeeGrant` method

* test the revoke command

Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant