Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link correction for docs #17799

Merged
merged 4 commits into from
Sep 19, 2023
Merged

docs: link correction for docs #17799

merged 4 commits into from
Sep 19, 2023

Conversation

samricotta
Copy link
Contributor

Description

Link is out of date and needs updating


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@samricotta samricotta requested a review from a team as a code owner September 19, 2023 05:30
@julienrbrt julienrbrt changed the title refactor: link correction for docs docs: link correction for docs Sep 19, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is is targeting v0.50 and not main?

@tac0turtle tac0turtle changed the base branch from release/v0.50.x to main September 19, 2023 08:12
@tac0turtle tac0turtle changed the base branch from main to release/v0.50.x September 19, 2023 08:12
@tac0turtle
Copy link
Member

please target main then backport

@tac0turtle tac0turtle closed this Sep 19, 2023
@tac0turtle tac0turtle deleted the sam/links-0.50 branch September 19, 2023 08:12
@samricotta
Copy link
Contributor Author

this is because this is already updated in main and not in 0.50 https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/build/building-modules/06-keeper.md?plain=1#L51

@tac0turtle tac0turtle restored the sam/links-0.50 branch September 19, 2023 10:04
@tac0turtle tac0turtle reopened this Sep 19, 2023
@tac0turtle tac0turtle merged commit b1208ef into release/v0.50.x Sep 19, 2023
8 of 36 checks passed
@tac0turtle tac0turtle deleted the sam/links-0.50 branch September 19, 2023 10:48
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants