Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(accounts): add Genesis handling #17802

Merged
merged 6 commits into from
Sep 21, 2023
Merged

feat(accounts): add Genesis handling #17802

merged 6 commits into from
Sep 21, 2023

Conversation

testinginprod
Copy link
Contributor

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@testinginprod testinginprod requested a review from a team as a code owner September 19, 2023 08:18
@github-prbot github-prbot requested review from a team, alexanderbez and atheeshp and removed request for a team September 19, 2023 08:18
@github-actions
Copy link
Contributor

@testinginprod your pull request is missing a changelog!

tac0turtle
tac0turtle approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UtACK

x/accounts/genesis.go
}

func (k Keeper) importAccount(ctx context.Context, acc *v1.GenesisState_GenesisAccount) error {
// TODO: maybe check if impl exists?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

likhita-809
likhita-809 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

julienrbrt
julienrbrt approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

proto/cosmos/accounts/v1/genesis.proto Outdated Show resolved Hide resolved
x/accounts/internal/implementation/context.go Outdated Show resolved Hide resolved
unknown unknown added 3 commits September 21, 2023 13:37
@testinginprod testinginprod added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit 5952ecf Sep 21, 2023
49 of 52 checks passed
@testinginprod testinginprod deleted the tip/accounts/genesis branch September 21, 2023 14:27
@testinginprod testinginprod mentioned this pull request Dec 19, 2023
Closed
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhita-809 likhita-809 likhita-809 approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@atheeshp atheeshp Awaiting requested review from atheeshp

Assignees

@facundomedica facundomedica

@tac0turtle tac0turtle

@likhita-809 likhita-809

Labels
C:x/accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@testinginprod @tac0turtle @julienrbrt @likhita-809 @facundomedica