Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove params module entirely #17838

Merged
merged 12 commits into from
Sep 22, 2023
Merged

chore: remove params module entirely #17838

merged 12 commits into from
Sep 22, 2023

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Sep 22, 2023

Description

Closes: #17360

this pr is meant to remove the params modules entirely as its no longer needed.

This is blocked on #17837


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle changed the title remove params module enitrely chore: remove params module enitrely Sep 22, 2023
@tac0turtle tac0turtle changed the title chore: remove params module enitrely chore: remove params module entirely Sep 22, 2023
Base automatically changed from marko/17360_4 to main September 22, 2023 09:37
@tac0turtle tac0turtle marked this pull request as ready for review September 22, 2023 09:57
@tac0turtle tac0turtle requested a review from a team as a code owner September 22, 2023 09:57
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is closing the wrong issue. Can we add a small disclaimer in the UPGRADING.md about the need when migrating from v0.45 and v0.46 to migrate to v0.50 or v0.47 before v0.51?

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • The race detected looks unrelated
  • The failing test (TestQueryAppConfig) it's because we need to remove "params" from the modules list

@julienrbrt julienrbrt added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit 65a1ec6 Sep 22, 2023
53 checks passed
@julienrbrt julienrbrt deleted the marko/17360_5 branch September 22, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Epic]: Remove legacy params subspace from module
4 participants