Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x/auth): properly populate tx config options and deprecate ProtoCodecMarshaler #17946

Merged
merged 8 commits into from
Oct 4, 2023
Merged

fix(x/auth): properly populate tx config options and deprecate ProtoCodecMarshaler #17946

merged 8 commits into from
Oct 4, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Oct 3, 2023 •
edited
Loading

Description

Extract changes from #17913
Namely:

  • codec.Codec and codec.ProtoCodecMarshaler are the same, so deprecate ProtoCodecMarshaler for simplifying the API (this isn't breaking).
  • Add hardening to give a better error when if tx encoders aren't set.
  • Fix bug in x/auth/tx where options weren't kept.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner October 3, 2023 11:37
@github-actions github-actions bot added the C:CLI label Oct 3, 2023
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Oct 3, 2023
@julienrbrt julienrbrt changed the title refactor: add autocli keyring wraper and simplify ProtoCodecMarshaler… refactor: add autocli keyring wrapper and simplify ProtoCodecMarshaler Oct 3, 2023
@julienrbrt julienrbrt changed the title refactor: add autocli keyring wrapper and simplify ProtoCodecMarshaler refactor: add autocli keyring wrapper and deprecate ProtoCodecMarshaler Oct 3, 2023
julienrbrt
julienrbrt commented Oct 3, 2023
View reviewed changes
x/auth/tx/config.go
txConfig := &config{
protoCodec: protoCodec,
protoCodec: protoCodec,
decoder: configOptions.ProtoDecoder,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

custom encoder/decoder were never populated.

@julienrbrt julienrbrt changed the title refactor: add autocli keyring wrapper and deprecate ProtoCodecMarshaler fix(x/auth): properly populate tx config options and deprecate ProtoCodecMarshaler Oct 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

@julienrbrt your pull request is missing a changelog!

@julienrbrt
Copy link
Member Author

@julienrbrt your pull request is missing a changelog!

Unreleased changes, changelog not needed.

odeke-em
odeke-em approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @julienrbrt, LGTM mostly with some comments.

client/tx/factory.go Outdated Show resolved Hide resolved
client/tx/tx.go Outdated Show resolved Hide resolved
codec/proto_codec.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt added this pull request to the merge queue Oct 4, 2023
Merged via the queue into main with commit 76f8ed1 Oct 4, 2023
50 checks passed
@julienrbrt julienrbrt deleted the julien/refactors-autocli branch October 4, 2023 07:31
mergify bot pushed a commit that referenced this pull request Oct 4, 2023
@julienrbrt @mergify
fix(x/auth): properly populate tx config options and deprecate `Proto…
909e457 
…CodecMarshaler` (#17946)

(cherry picked from commit 76f8ed1)
@mergify mergify bot mentioned this pull request Oct 4, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Oct 4, 2023
@mergify
fix(x/auth): properly populate tx config options and deprecate `Proto…
3da9f9c 
…CodecMarshaler` (backport #17946) (#17952)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odeke-em odeke-em odeke-em approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @odeke-em