-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/distribution): add autocli options for tx #17963
Conversation
I need to add msg server tests as part of this PR. |
I'll be partially backporting this PR (test addition, autocli config but the not other module changes that require v0.51) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, there is a command from authz using address codec, that can also be refactored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of nits
Yep, done in the authz follow-up PR (#18039). |
(cherry picked from commit 44934e3) # Conflicts: # CHANGELOG.md # tests/e2e/distribution/suite.go # tests/e2e/distribution/withdraw_all_suite.go # x/bank/client/cli/tx.go # x/bank/client/cli/tx_test.go # x/distribution/client/cli/tx.go # x/distribution/client/cli/tx_test.go # x/distribution/keeper/keeper_test.go # x/protocolpool/autocli.go # x/staking/client/cli/tx.go
Description
Closes: #17962
Blocked on
#17913and#17868Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change