Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(x/crisis): add autocli options for tx #17965

Merged
merged 6 commits into from
Oct 6, 2023
Merged

feat(x/crisis): add autocli options for tx #17965

merged 6 commits into from
Oct 6, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Oct 4, 2023 •
edited
Loading

Description

Closes: #17964

Blocked on #17913

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added S:blocked Status: Blocked backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Oct 4, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner October 4, 2023 23:07
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

@julienrbrt your pull request is missing a changelog!

Base automatically changed from julien/autocli-from to main October 5, 2023 11:06
@julienrbrt julienrbrt removed the S:blocked Status: Blocked label Oct 5, 2023
@tac0turtle tac0turtle added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit 12b45f3 Oct 6, 2023
51 checks passed
@tac0turtle tac0turtle deleted the julien/autocli-tx-crisis branch October 6, 2023 08:10
mergify bot pushed a commit that referenced this pull request Oct 6, 2023
@julienrbrt @mergify
feat(x/crisis): add autocli options for tx (#17965)
b86d9c4 
(cherry picked from commit 12b45f3)

# Conflicts:
#	x/crisis/client/cli/tx_test.go
#	x/crisis/module.go
@mergify mergify bot mentioned this pull request Oct 6, 2023
Merged
tac0turtle added a commit that referenced this pull request Oct 6, 2023
@mergify @julienrbrt @tac0turtle
feat(x/crisis): add autocli options for tx (backport #17965) (#17982)
a2f2c92 
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/crisis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AutoCLI Tx Options for x/crisis
2 participants
@julienrbrt @tac0turtle