Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tendermint v0.22.6-rc0 #1798

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Conversation

ValarDragon
Copy link
Contributor

@ValarDragon ValarDragon commented Jul 23, 2018

This just updates to the crypto refactor in tendermint v0.22.5. This is ready for review.

This shouldn't be merged in until after that PR is merged / whenever this lands in a release, but figured I should make the PR now.

We just need to decide if we want to wait until tendermint v22.5 is merged, or just update sdk develop to tendermint develop.

  • Linked to github-issue with discussion and accepted design - n/a
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests - n/a
  • Added entries in PENDING.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #1798 into develop will increase coverage by 0.02%.
The diff coverage is 54.54%.

@@             Coverage Diff             @@
##           develop    #1798      +/-   ##
===========================================
+ Coverage    63.44%   63.46%   +0.02%     
===========================================
  Files          117      117              
  Lines         6937     6922      -15     
===========================================
- Hits          4401     4393       -8     
+ Misses        2281     2274       -7     
  Partials       255      255

@ValarDragon
Copy link
Contributor Author

ValarDragon commented Jul 24, 2018

#2034 has now been merged into the v22.5 branch. Once v22.5 is merged / tagged, we should be able to change the gopkg and have everything work.

Alternatively I can just change the revision to be whats on tendermint develop, and we can go ahead and merge this now.

@ValarDragon ValarDragon changed the title Update to tendermint post crypto-refactor Update to tendermint v0.22.5 Jul 24, 2018
@ValarDragon
Copy link
Contributor Author

Just updated this to v0.22.5 and squashed. This should be good to merge now.

This is comprised of updating the crypto imports / API
@ValarDragon ValarDragon changed the title Update to tendermint v0.22.5 Update to tendermint v0.22.6-rc0 Jul 25, 2018
@ValarDragon
Copy link
Contributor Author

Its now updated to v0.22.6-rc0, for the next testnet.

If this passes tests, I'll squash this commit and update the PR.
Copy link
Member

@ebuchman ebuchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ebuchman ebuchman merged commit 5d02a74 into develop Jul 25, 2018
@ebuchman ebuchman deleted the dev/update_tendermint_crypto branch July 25, 2018 20:43
ebuchman pushed a commit that referenced this pull request Jul 25, 2018
* Update to tendermint v0.22.6

- This was cherry-picked and fixed from develop
- Updates all crypto imports for changes from v0.22.5
ebuchman pushed a commit that referenced this pull request Jul 25, 2018
* Update to tendermint v0.22.6

- This was cherry-picked and fixed from develop
- Updates all crypto imports for changes from v0.22.5
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants