Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/staking): autocli tx support #17986

Merged
merged 9 commits into from
Oct 10, 2023
Merged

feat(x/staking): autocli tx support #17986

merged 9 commits into from
Oct 10, 2023

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Oct 6, 2023

Description

Closes: #17973


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp marked this pull request as ready for review October 10, 2023 06:42
@atheeshp atheeshp requested a review from a team as a code owner October 10, 2023 06:42
@github-prbot github-prbot requested review from a team, kocubinski and likhita-809 and removed request for a team October 10, 2023 06:42
@github-actions

This comment has been minimized.

tests/e2e/staking/test_helpers.go Outdated Show resolved Hide resolved
x/staking/autocli.go Outdated Show resolved Hide resolved
x/staking/autocli.go Outdated Show resolved Hide resolved
x/staking/autocli.go Outdated Show resolved Hide resolved
x/staking/autocli.go Outdated Show resolved Hide resolved
@atheeshp atheeshp added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit f149f1b Oct 10, 2023
48 of 49 checks passed
@atheeshp atheeshp deleted the ap/staking-tx-autocli branch October 10, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoCLI Tx Options for x/staking
2 participants