Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/gov): add autocli options for tx #18036

Merged
merged 11 commits into from
Oct 12, 2023
Merged

feat(x/gov): add autocli options for tx #18036

merged 11 commits into from
Oct 12, 2023

Conversation

julienrbrt
Copy link
Member

Description

Closes: #18014
More gov cli clean-up happens here: #18025


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt marked this pull request as ready for review October 10, 2023 11:09
@julienrbrt julienrbrt requested a review from a team as a code owner October 10, 2023 11:09
@github-prbot github-prbot requested review from a team, tac0turtle and atheeshp and removed request for a team October 10, 2023 11:09
@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link
Contributor

@julienrbrt your pull request is missing a changelog!

@julienrbrt julienrbrt enabled auto-merge October 11, 2023 10:32
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienrbrt julienrbrt added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit fe99b0c Oct 12, 2023
49 of 50 checks passed
@julienrbrt julienrbrt deleted the julien/autocli-gov-tx branch October 12, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoCLI Tx Options for x/gov
2 participants