refactor(client/keys): hide inputting when keys add -i ask for bip39 passphrase

[Halimao]

Description

I think we should hide the inputting for bip39 passphrase when running <simd> keys add -i, and there is a repeat confirmation flow already here

Note:

This maybe break some old scripts that using length < 8 passphrase

Screenshots

Case using empty passphrase:

Case using custom passphrase hat length > 8:

Case using custom passphrase that length < 8:

[coderabbitai]

Walkthrough

The changes involve enhancing security and robustness in the handling of sensitive input, specifically for key management in the client application. The passphrase input process now hides the input and checks for minimum length, improving security. Additionally, the update includes error handling for non-existent or unauthorized module accounts in the x/bank module, and improved genesis validation in the x/gov module. These modifications aim to reduce the risk of errors and increase the application's resilience against potential misuse.

Changes

Files	Summary
client/keys/add.go	Enhanced passphrase input security with hidden input and minimum length check. Improved handling for multisig duplicate keys.
client/keys/add_test.go	Updated tests to cover interactive key generation with password input validation.
client/input/input.go	Added GetSecretString function for secure input retrieval.
CHANGELOG.md	Documented improvements in client/keys, x/gov, and x/bank modules. Error handling in x/bank for module account issues and improved genesis validation in x/gov.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can reply to a review comment made by CodeRabbit.
• You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
• You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[julienrbrt]

This maybe break some old scripts that using length < 8 passphrase

Yeah, so I don't think we can merge that. People having short passwords would get locked out of re-adding their keys on a new machine.

[Halimao]

This maybe break some old scripts that using length < 8 passphrase

Yeah, so I don't think we can merge that. People having short passwords would get locked out of re-adding their keys on a new machine.

Okay, let's just remove the length limitation~

[Halimao]

This maybe break some old scripts that using length < 8 passphrase

Yeah, so I don't think we can merge that. People having short passwords would get locked out of re-adding their keys on a new machine.

@julienrbrt Done, I have reverted the limit for inputting length

[julienrbrt]

ACK. I hope people will write it down properly and don't make the same typo twice :D