Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core)!: move ParseCoins to client/v2/internal #18861

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

tac0turtle
Copy link
Member

Description

This pr moves parse coins to client/v2/internal, where it is used


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@tac0turtle tac0turtle marked this pull request as ready for review December 21, 2023 17:45
@tac0turtle tac0turtle requested a review from a team as a code owner December 21, 2023 17:45
Copy link
Contributor

coderabbitai bot commented Dec 21, 2023

Walkthrough

The Cosmos SDK has undergone a reorganization, particularly affecting the handling of coins. The coin.ParseCoin function and related coin formatting utilities have been moved from the core package to an internal package within the client/v2 directory. This shift suggests a refactoring effort to internalize coin-related functionalities, likely for encapsulation or modularization purposes. As a result, import paths and function usages have been updated across various test and implementation files to align with the new structure.

Changes

File Summary
client/v2/autocli/flag/coin.go
client/v2/internal/coins/format_test.go
Changed import paths from "cosmossdk.io/core/coins" to "cosmossdk.io/client/v2/internal/coins".
core/CHANGELOG.md Updated documentation to reflect the movement of coin.ParseCoin to client/v2/internal.
x/tx/signing/textual/coins_test.go Removed import for cosmossdk.io/core/coins and updated function calls from coins.FormatCoins to textual.FormatCoins.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@tac0turtle tac0turtle added this pull request to the merge queue Dec 21, 2023
Merged via the queue into main with commit 055487e Dec 21, 2023
60 of 61 checks passed
@tac0turtle tac0turtle deleted the marko/move_parsecoins branch December 21, 2023 18:30
timtide pushed a commit to timtide/cosmos-sdk that referenced this pull request Dec 26, 2023
@coderabbitai coderabbitai bot mentioned this pull request Feb 8, 2024
12 tasks
@coderabbitai coderabbitai bot mentioned this pull request May 3, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants