feat(accounts): Add TxCompat field – implement Tx integration (part 1) #18969

testinginprod · 2024-01-07T12:40:26Z

Description

This is one of the multiple PRs required to allow x/accounts authentication and execution logic to be invoked when no bundler is involved.

In fact when a user which owns an abstracted account is trying to send a TX, the TX is converted into a UserOperation,
such that authentication and execution flow of the TX are taken over by the AA implementation.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

coderabbitai · 2024-01-07T12:40:39Z

Walkthrough

The Cosmos blockchain has updated its account abstraction layer, integrating transaction compatibility features and refining error handling. A new message type, TxCompat, is introduced to check transaction compatibility, and tests are adjusted to account for this. A specific error is added to prevent TxCompat from being used in bundles, ensuring transactions conform to the new rules. The execution function now handles bundler and operations distinctly, streamlining the response process.

Changes

File Path	Change Summary
`proto/cosmos/accounts/v1/account_abstraction.proto`	Modified `authentication_data` field, added import for signing proto, introduced `TxCompat` message.
`tests/e2e/accounts/account_abstraction_test.go`	Added new test for `TxCompat` failure, updated existing tests, adjusted test parameters and gas limits.
`x/accounts/keeper_account_abstraction.go`	Added `ErrDisallowedTxCompatInBundle` error, disallowed `TxCompat` field in `UserOperation` sent from a bundle.
`x/accounts/msg_server.go`	Removed imports of "google.golang.org/grpc/codes" and "google.golang.org/grpc/status", modified `ExecuteBundle` function to handle `req.Bundler` and `req.Operations` differently.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

github-actions · 2024-01-07T12:40:44Z

@testinginprod your pull request is missing a changelog!

testinginprod · 2024-01-07T12:41:17Z

x/accounts/msg_server.go

@@ -103,5 +100,15 @@ func (m msgServer) Execute(ctx context.Context, execute *v1.MsgExecute) (*v1.Msg
 }

 func (m msgServer) ExecuteBundle(ctx context.Context, req *v1.MsgExecuteBundle) (*v1.MsgExecuteBundleResponse, error) {
-	return nil, status.Error(codes.Unimplemented, "not implemented")
+	_, err := m.k.addressCodec.StringToBytes(req.Bundler)


NOTE: this is not related to the PR but I just saw the MsgServer logic was missing (probably got nuked in a merge).

testinginprod · 2024-01-07T12:41:30Z

tests/e2e/accounts/account_abstraction_test.go

+
+var mockSignature = &codectypes.Any{TypeUrl: "signature", Value: []byte("signature")}
+
+func setupApp(t *testing.T) *simapp.SimApp {


look: https://github.com/cosmos/cosmos-sdk/pull/18969/files#r1443998246

facundomedica

LGTM. A single question, why can't we use the existing Tx/TxRaw or SignDoc for TxCompat?

testinginprod · 2024-01-07T14:05:20Z

LGTM. A single question, why can't we use the existing Tx/TxRaw or SignDoc for TxCompat?

to avoid the dependency.

The idea is that:

Bundler sends UserOp
User sends TX which is converted into UserOp.

So we need to retrofit some TX fileds into the user op. The main reason for having authinfo bytes and tx body bytes is not to need to re-encode things otherwise we might have discrepancies in the signature. (EG clients encode auth in some bytes and the state machine encodes them in a different way). Unluckily it's a limitation of protobuf encoding.

…1) (cosmos#18969) Co-authored-by: unknown unknown <unknown@unknown>

unknown unknown added 2 commits January 7, 2024 13:27

do preliminary changes required for TX integration

ebf85b0

add more testing and adjust tx compat semantics

40446b8

testinginprod requested a review from a team as a code owner January 7, 2024 12:40

testinginprod changed the title ~~feat(accounts): Implement Tx integration~~ feat(accounts): Implement Tx integration (part 1) Jan 7, 2024

github-actions bot added the C:x/accounts label Jan 7, 2024

testinginprod commented Jan 7, 2024

View reviewed changes

unknown unknown added 2 commits January 7, 2024 13:42

fix proto

2597b94

fix proot generation of account_abstraction.pb.go

3d0d947

testinginprod changed the title ~~feat(accounts): Implement Tx integration (part 1)~~ feat(accounts): Add TxCompat field – implement Tx integration (part 1) Jan 7, 2024

testinginprod mentioned this pull request Jan 7, 2024

Epic: x/accounts #17786

Closed

44 tasks

facundomedica approved these changes Jan 7, 2024

View reviewed changes

alexanderbez approved these changes Jan 7, 2024

View reviewed changes

testinginprod added this pull request to the merge queue Jan 8, 2024

Merged via the queue into main with commit 6848448 Jan 8, 2024
62 of 64 checks passed

testinginprod deleted the tip/accounts/tx_integration_1 branch January 8, 2024 10:16

relyt29 pushed a commit to relyt29/cosmos-sdk that referenced this pull request Jan 22, 2024

feat(accounts): Add TxCompat field – implement Tx integration (part …

85363ce

…1) (cosmos#18969) Co-authored-by: unknown unknown <unknown@unknown>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(accounts): Add TxCompat field – implement Tx integration (part 1) #18969

feat(accounts): Add TxCompat field – implement Tx integration (part 1) #18969

testinginprod commented Jan 7, 2024

coderabbitai bot commented Jan 7, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

github-actions bot commented Jan 7, 2024

testinginprod Jan 7, 2024

testinginprod Jan 7, 2024

facundomedica left a comment

testinginprod commented Jan 7, 2024


		var mockSignature = &codectypes.Any{TypeUrl: "signature", Value: []byte("signature")}

		func setupApp(t testing.T) simapp.SimApp {

feat(accounts): Add TxCompat field – implement Tx integration (part 1) #18969

feat(accounts): Add TxCompat field – implement Tx integration (part 1) #18969

Conversation

testinginprod commented Jan 7, 2024

Description

Author Checklist

Reviewers Checklist

coderabbitai bot commented Jan 7, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

github-actions bot commented Jan 7, 2024

testinginprod Jan 7, 2024

Choose a reason for hiding this comment

testinginprod Jan 7, 2024

Choose a reason for hiding this comment

facundomedica left a comment

Choose a reason for hiding this comment

testinginprod commented Jan 7, 2024

coderabbitai bot commented Jan 7, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)