-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(accounts): Add Query to simulate a UserOperation #18979
Conversation
WalkthroughThe recent modifications involve enhancing the Cosmos blockchain's account system by introducing account abstraction capabilities. A new RPC method, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@testinginprod your pull request is missing a changelog! |
how come this is needed over the global simulation method? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explained the need in a call. Can you update the pr description so readers know the reason for this feature @testinginprod
Co-authored-by: unknown unknown <unknown@unknown>
Description
SimulateUserOperation can be used by Bundlers to simulate the outcome of the execution of a UserOp.
The rationale for not using SimulateTX is to give granularity over the operation itself.
If we were to simulate a TX the bundler would most likely receive a response with more information pertaining the execution of the TX and not the operation itself. This also removes burden from the state machine to execute a full tx when only the op is needed.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...