Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accounts): Add codec.BinaryCodec and Gas to dependencies. #19068

Merged
merged 7 commits into from
Jan 17, 2024

Conversation

testinginprod
Copy link
Contributor

Description

This PR allows accounts to have access to the binary codec, which is required for saving in state protobuf objects, and the gas service which is useful for AA implementers that need to consume gas (eg: sig verify gas cost).


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@testinginprod testinginprod requested a review from a team as a code owner January 15, 2024 21:00
Copy link
Contributor

coderabbitai bot commented Jan 15, 2024

Walkthrough

The Cosmos SDK application has undergone a significant update with the introduction of new functionalities for testing dependencies and interacting with gas meters. The updates include new message types for testing, a GasService struct for gas interactions, and the implementation of this service across account components. Additionally, there are modifications to keepers and account utilities to accommodate these new features, including changes in the wiring and encoding mechanisms.

Changes

File Path Change Summary
proto/cosmos/accounts/testing/counter/v1/counter.proto Introduced MsgTestDependencies and MsgTestDependenciesResponse messages for testing dependencies.
runtime/gas.go, simapp/app.go Implemented GasService struct for interacting with gas meters and modified NewSimApp to include runtime.GasService{} in the creation of accountsKeeper.
tests/e2e/accounts/wiring_test.go Introduced TestDependencies to test wiring between different account components inherited from the runtime.
x/accounts/internal/implementation/context.go, x/accounts/internal/implementation/implementation.go Updated imports, introduced gasService, refactored headerService, and updated several functions to use parentContext instead of originalContext.
x/accounts/internal/implementation/encoding.go, x/accounts/internal/implementation/protoaccount.go Added and removed imports for proto message interfaces.
x/accounts/keeper.go, x/accounts/internal/implementation/implementation.go, x/accounts/testing/counter/counter.go Added new imports, parameters, and modified functions to accommodate the GasService and related changes.
x/accounts/utils_test.go Modified newKeeper function call to pass an additional nil argument.
codec/collections.go Updated the CollValue function's signature to accept an interface instead of BinaryCodec.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@testinginprod testinginprod mentioned this pull request Jan 15, 2024
44 tasks
codec/collections.go Outdated Show resolved Hide resolved
@testinginprod testinginprod added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit 498cd6a Jan 17, 2024
61 of 62 checks passed
@testinginprod testinginprod deleted the tip/accounts/add_codec_gas branch January 17, 2024 10:59
relyt29 pushed a commit to relyt29/cosmos-sdk that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants