-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bump go to 1.22 #19396
ci: bump go to 1.22 #19396
Conversation
WalkthroughThe recent updates involve upgrading the Go version from 1.21 to 1.22 across various components of the project, including Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yml
Files selected for processing (19)
- .github/workflows/build.yml (1 hunks)
- .github/workflows/codeql-analysis.yml (1 hunks)
- .github/workflows/dependabot-update-all.yml (1 hunks)
- .github/workflows/dependencies-review.yml (1 hunks)
- .github/workflows/lint.yml (1 hunks)
- .github/workflows/release-confix.yml (1 hunks)
- .github/workflows/release-cosmovisor.yml (1 hunks)
- .github/workflows/release.yml (1 hunks)
- .github/workflows/sims-047.yml (5 hunks)
- .github/workflows/sims-050.yml (5 hunks)
- .github/workflows/sims-nightly.yml (2 hunks)
- .github/workflows/sims.yml (4 hunks)
- .github/workflows/starship-tests.yml (1 hunks)
- .github/workflows/test.yml (30 hunks)
- Dockerfile (1 hunks)
- go.work.example (1 hunks)
- simapp/go.mod (1 hunks)
- tests/go.mod (1 hunks)
- tests/starship/tests/go.mod (1 hunks)
Files skipped from review due to trivial changes (9)
- .github/workflows/build.yml
- .github/workflows/dependencies-review.yml
- .github/workflows/lint.yml
- .github/workflows/release.yml
- .github/workflows/sims-050.yml
- .github/workflows/sims-nightly.yml
- .github/workflows/sims.yml
- .github/workflows/test.yml
- simapp/go.mod
Additional comments: 8
go.work.example (2)
- 1-1: Update to Go 1.22 is correct and aligns with the PR objectives.
- 3-3: Toolchain version update to
go1.22.0
is correct and consistent with the Go version update.tests/go.mod (2)
- 3-3: Update to Go 1.22 is correct and aligns with the PR objectives.
- 5-5: Toolchain version update to
go1.22.0
is correct and consistent with the Go version update.tests/starship/tests/go.mod (4)
- 3-3: The Go version is correctly updated to 1.22, aligning with the PR objectives to use Go 1.22 in CI processes and specific applications.
- 5-5: The addition of
toolchain go1.22.0
is appropriate for specifying the Go version toolchain, ensuring that the correct version is used for builds.- 1-8: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [7-35]
Ensure that the local path replacements in the
replace
directive are correctly pointing to the intended modules and versions, especially considering the update to Go 1.22.
- 1-8: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [37-205]
Review the
require
directives for both direct and indirect dependencies to ensure they are compatible with Go 1.22 and do not introduce any version conflicts or deprecated packages.
I say we wait a little bit before merging since it's not been updated everywhere (eg: homebrew) |
Makes sense. It isn't updated on nixpkgs either, so ci won't let it go through. |
go 1.21 | ||
go 1.22 | ||
|
||
toolchain go1.22.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have to remove this to allow people to use lower versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is why it is only in simapp and packages that depends on simapp (tests and starship tests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 6
Configuration used: .coderabbit.yml
Files selected for processing (4)
- contrib/devtools/Dockerfile (1 hunks)
- contrib/images/simd-dlv/Dockerfile (1 hunks)
- contrib/images/simd-env/Dockerfile (1 hunks)
- flake.nix (1 hunks)
Files skipped from review due to trivial changes (1)
- contrib/images/simd-dlv/Dockerfile
Additional comments: 5
contrib/devtools/Dockerfile (2)
- 6-6: Ensure all dependencies installed via
apk add
andnpm install
are compatible with Alpine Linux running with Go 1.22 to avoid potential runtime issues.- 6-6: Verify that the versions of the tools installed with
go install
are compatible with Go 1.22 to ensure the Docker image functions as expected.contrib/images/simd-env/Dockerfile (2)
- 1-1: Updating to
golang:1.22-alpine
is aligned with the PR objectives. Ensure all dependencies and build tools are compatible with this Go version.- 1-1: Verify that the
make clean build
command is fully compatible with Go 1.22 and does not rely on deprecated or removed features.flake.nix (1)
- 56-56: Updating to
go_1_22
inbuildInputs
aligns with the PR objectives. Ensure all dependencies specified in the Nix expression are compatible with Go 1.22.
We just now need to wait until homebrew bumps Go and nixpkgs as well: Homebrew/homebrew-core#157782, then let's merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yml
Files selected for processing (3)
- simapp/go.mod (1 hunks)
- tests/go.mod (1 hunks)
- tests/starship/tests/go.mod (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- simapp/go.mod
- tests/go.mod
- tests/starship/tests/go.mod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yml
Files selected for processing (5)
- Dockerfile (1 hunks)
- contrib/images/simd-env/Dockerfile (1 hunks)
- simapp/go.mod (1 hunks)
- tests/go.mod (1 hunks)
- tests/starship/tests/go.mod (1 hunks)
Files skipped from review as they are similar to previous changes (5)
- Dockerfile
- contrib/images/simd-env/Dockerfile
- simapp/go.mod
- tests/go.mod
- tests/starship/tests/go.mod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yml
Files selected for processing (3)
- simapp/go.mod (1 hunks)
- tests/go.mod (1 hunks)
- tests/starship/tests/go.mod (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- simapp/go.mod
- tests/go.mod
- tests/starship/tests/go.mod
@yihuang any help here with nix: https://github.com/cosmos/cosmos-sdk/actions/runs/7976846552/job/21778336332?pr=19396 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yml
Files selected for processing (3)
- simapp/go.mod (1 hunks)
- tests/go.mod (1 hunks)
- tests/starship/tests/go.mod (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- simapp/go.mod
- tests/go.mod
- tests/starship/tests/go.mod
it says,
|
…ntal-features flakes u pdate nixpkgs`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yml
Files selected for processing (1)
- flake.lock (1 hunks)
Additional comments: 1
flake.lock (1)
- 46-50: The updates to the
nixpkgs
dependency in theflake.lock
file, including changes to thelastModified
,narHash
, andrev
values, are appropriate for aligning the Nix environment with the updated Go version 1.22. These changes ensure that the build environment and dependencies are consistent with the new requirements. It's important to verify that these updates do not introduce any compatibility issues with the existing codebase or other dependencies.
Description
Bump CI to use Go 1.22, and simapp to use Go 1.22.
However, as the sdk is a library, and we don't have Go 1.22 specific features we want to use, we keep our minimum Go version to Go 1.21.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
go1.22.0
in relevant configuration files.flake.lock
file with changes innixpkgs
dependency, reflecting version updates.