build(deps): bump prometheus and client_golang in v0.50.x

[Reecepbcups]

Description

Closes: #XXXXX

NOTE: this points to the v0.50.x release branch

github.com/prometheus/client_golang v1.18.0 in the v0.50.5 release has a breaking change. This change breaks importing the SDK. It was fixed in client_golang v1.19 and prometheus/common v0.48+.

Further, references on this change

• prometheus/common@v0.47.0...v0.48.0
• Build break after updating prometheus/client_golang#1446

v0.50.5 import (v1.18.0)

v0.50.5 + v1.19.0 fix ( this branch)

This also affects interchaintest, so not just this repo Stride IBC repo -> strangelove-ventures/interchaintest#1037

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

[julienrbrt]

We can bump, but v0.50.5 does not have any breaking change. We didn't bump that dependency at all, as it was indeed introducing a breaking change.

I am all for bumping however (#19846 (comment)) and it makes our update all go mod script works better.

[julienrbrt]

Can we stay consistent with main: https://github.com/cosmos/cosmos-sdk/blob/main/telemetry/metrics.go#L204

[julienrbrt]

Thank you for your contribution. Given that it is implemented by this commit: 7397b86, from this PR: #19810, this superseded this PR.
In our next monthly release (over two weeks), we'll tag a v0.50.6 with this change and tag our submodules (not needed, but still good to do).

Meanwhile, you need to stay on v0.47 of prometheus and client_golang v1.18.