fix: remove useless condition

[ipangpang]

Description

remove useless condition

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Bug Fixes
  • Removed an unnecessary error check in the dependency injection mechanism to streamline operations.
  • Adjusted error handling in the simulation helper to ensure more accurate function returns.

[coderabbitai]

Walkthrough

Walkthrough

The modifications involve simplifying error handling in two different files. In container.go, an error check was removed from the addNode method, potentially streamlining the process of adding nodes to the container. Similarly, in app_helpers.go, the NextBlock function was adjusted to always return nil for the error, simplifying its error handling and possibly making the function's behavior more predictable.

Changes

File	Change Summary
depinject/container.go	Removed an error check in the addNode method.
testutil/.../app_helpers.go	Modified NextBlock to return nil for the error instead of err.

---

Recent Review Details

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between f31a6a3 and 865d278.

Files selected for processing (2)

• depinject/container.go (1 hunks)
• testutil/sims/app_helpers.go (1 hunks)

Additional Context Used

Path-based Instructions (2)

testutil/sims/app_helpers.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

depinject/container.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (2)

testutil/sims/app_helpers.go (1)

133-133: Ensure that error handling is appropriately managed upstream since NextBlock now always returns nil for the error.

This change simplifies the function but requires careful consideration of how errors are handled in the calling code. Please verify that all error scenarios that could occur in the operations within NextBlock are handled or logged appropriately before this change.

depinject/container.go (1)

Line range hint 133-133: Ensure that the removal of the error check does not introduce potential issues in the dependency resolution process.

The removal of an error check can simplify the code but might also lead to overlooking some edge cases where the error would be necessary. Please ensure that all scenarios where the error check was previously useful are now either impossible due to other logic or handled elsewhere in the code.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.