chore: fix malformed struct tag

[ipangpang]

Description

In a Go struct, private fields are not exported even without the json:"-" struct tag. If a struct tag json:"-" is present, even public fields will not be exported.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Bug Fixes
  • Corrected field naming inconsistencies in proposal submission functions, ensuring accurate data handling.
• Refactor
  • Updated JSON marshaling settings for configuration parsing, improving data representation and storage.
• Documentation
  • Updated workflow concurrency settings and job configurations for improved workflow execution.
  • Removed embedded grpc-web proxy in favor of standalone proxy for enhanced server functionality.
• Tests
  • Added new test suites and utilities for end-to-end testing of lockup functionality in the accounts module.
• Chores
  • Adjusted Makefile targets and removed gRPC-Web configurations for cleaner build processes.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve standardizing field names by renaming proposalType to ProposalType in the governance module's client CLI code for consistency. Additionally, adjustments were made in the upgrade module, such as removing the json:"-" tag from the parseConfig field, potentially affecting JSON serialization.

Changes

File(s)	Change Summary
x/gov/client/cli/util.go	Renamed proposalType to ProposalType in the proposal struct. Updated field assignment in parseSubmitProposal.
x/upgrade/plan/info.go	Removed json:"-" tag from parseConfig field, impacting JSON serialization.

---

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 11d4e74 and 9daa715.

Files selected for processing (2)

• x/gov/client/cli/util.go (1 hunks)
• x/upgrade/plan/info.go (1 hunks)

Files skipped from review as they are similar to previous changes (2)

• x/gov/client/cli/util.go
• x/upgrade/plan/info.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[julienrbrt]

Thank you!
Could you bring back proposalType private?

[ipangpang]

Thank you! Could you bring back proposalType private?

Sure, I have reverted proposalType back to private.