Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove repetitive words #20180

Merged
merged 1 commit into from
Apr 25, 2024
Merged

chore: remove repetitive words #20180

merged 1 commit into from
Apr 25, 2024

Conversation

goofylfg
Copy link
Contributor

@goofylfg goofylfg commented Apr 24, 2024

Description

use https://github.com/Abirdcfly/dupword to check duplicate words in the source code (usually miswritten)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Bug Fixes

    • Corrected typos in various comments across multiple files to improve code clarity.
    • Updated an error message in Decode method for better accuracy.
  • Documentation

    • Updated the deprecation message in module.go to guide users towards using the recommended interface.

@goofylfg goofylfg requested a review from a team as a code owner April 24, 2024 16:43
Copy link
Contributor

coderabbitai bot commented Apr 24, 2024

Walkthrough

Walkthrough

The recent updates primarily involve typo corrections across various test files and source code comments, enhancing code clarity and documentation accuracy. Additionally, a deprecation message was updated to guide developers towards using a more current interface, promoting best practices in code maintenance and usage.

Changes

Files Change Summary
store/storage/.../db_test.go, sqlite/db_test.go, storage_test_suite.go Corrected a typo in comments by removing duplicate words.
types/collections.go Modified an error message in the Decode method to correct a typo related to buffer size check.
types/dec_coin.go Updated a comment to accurately describe the NewDecCoins function.
types/module/module.go Updated the deprecation message for AppModule interface to recommend using appmodule.AppModule.
x/auth/ante/unorderedtx/snapshotter_test.go Fixed a typo in a comment by removing a duplicate word.

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 30383e6 and d1bdaa2.
Files selected for processing (7)
  • store/storage/rocksdb/db_test.go (1 hunks)
  • store/storage/sqlite/db_test.go (1 hunks)
  • store/storage/storage_test_suite.go (1 hunks)
  • types/collections.go (1 hunks)
  • types/dec_coin.go (1 hunks)
  • types/module/module.go (1 hunks)
  • x/auth/ante/unorderedtx/snapshotter_test.go (1 hunks)
Files skipped from review due to trivial changes (5)
  • store/storage/rocksdb/db_test.go
  • store/storage/sqlite/db_test.go
  • store/storage/storage_test_suite.go
  • types/dec_coin.go
  • x/auth/ante/unorderedtx/snapshotter_test.go
Additional Context Used
Path-based Instructions (2)
types/collections.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

types/module/module.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (2)
types/collections.go (1)

258-258: Updated error message in timeKeyCodec.Decode method enhances clarity by specifying expected buffer size.

types/module/module.go (1)

57-57: Updated deprecation message for AppModule provides clear guidance on using newer interfaces.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tac0turtle tac0turtle added this pull request to the merge queue Apr 25, 2024
Merged via the queue into cosmos:main with commit 00ec23c Apr 25, 2024
60 of 61 checks passed
meetrick pushed a commit to meetrick/cosmos-sdk that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants