perf: Make recheck not re-run validate basic #20208
Conversation
WalkthroughWalkthroughThe update enhances the Changes
Recent Review DetailsConfiguration used: .coderabbit.yml Files selected for processing (2)
Files skipped from review as they are similar to previous changes (1)
Additional Context UsedPath-based Instructions (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
ValarDragon
changed the title
This comment has been minimized.
This comment has been minimized.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
baseapp/baseapp.go
Outdated
| } | ||
|
|
||
| msgs := tx.GetMsgs() | ||
| if err := validateBasicTxMsgs(app.msgServiceRouter, msgs); err != nil { | ||
| return sdk.GasInfo{}, nil, nil, err | ||
| if mode != execModeReCheck { | ||
| if err := validateBasicTxMsgs(app.msgServiceRouter, msgs); err != nil { | ||
| return sdk.GasInfo{}, nil, nil, err | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).runTx (baseapp/baseapp.go:820)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).deliverTx (baseapp/baseapp.go:750)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).internalFinalizeBlock (baseapp/baseapp.go:713)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).FinalizeBlock (baseapp/baseapp.go:874)
| } | ||
|
|
||
| msgs := tx.GetMsgs() | ||
| if err := validateBasicTxMsgs(app.msgServiceRouter, msgs); err != nil { | ||
| return sdk.GasInfo{}, nil, nil, err | ||
| // run validate basic if mode != recheck. | ||
| // as validate basic is stateless, it is guaranteed to pass recheck, given that its passed checkTx. | ||
| if mode != execModeReCheck { | ||
| if err := validateBasicTxMsgs(app.msgServiceRouter, msgs); err != nil { | ||
| return sdk.GasInfo{}, nil, nil, err | ||
| } |
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).runTx (baseapp/baseapp.go:820)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).deliverTx (baseapp/baseapp.go:750)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).internalFinalizeBlock (baseapp/baseapp.go:713)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).FinalizeBlock (baseapp/baseapp.go:874)
|
Thank you for the quick merge! |
Description
Make recheck Tx not re-run validate basic.
Important due to cometbft/cometbft#2925
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit