fix(x/consensus): apply ConsensusParam update rules according to CometBFT spec #20314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tac0turtle
approved these changes
May 8, 2024
julienrbrt
reviewed
May 8, 2024
|
ah yea, this should target main, missed that. im not sure this is safe to backport |
Co-authored-by: Marko <marko@baricevic.me>
I'll adapt this to I didn't target But, 100% agree that PRs should first tackle |
sergio-mena
commented
May 10, 2024
| return nil, err | ||
| } | ||
|
|
||
| if err := params.ValidateUpdate(&consensusParams, k.HeaderService.HeaderInfo(ctx).Height); err != nil { |
There was a problem hiding this comment.
k.HeaderService doesn't seem to work on release/v0.50.x. Consider reverting it
12 tasks
12 tasks
|
superseded by #20381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to: #20313
This PR modifies
consensusParamsKeeper.UpdateParams(...)so that its checks:ConsensusParamsIt also extends the unit tests logic to test the stateful functionality: the new unit tests fail without the changes in
consensusParamsKeeper.UpdateParams(...)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...