refactor(sims)!: Remove Baseapp from sims #21039
Conversation
github-actions
bot
added
C:x/staking
C:x/gov
C:x/slashing
C:x/distribution
WalkthroughWalkthroughThis update introduces significant enhancements to the Cosmos SDK, primarily focusing on the simulation framework. Key changes include the introduction of the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Simulation
participant AppEntrypoint
User->>Simulation: Request simulation
Simulation->>AppEntrypoint: Deliver simulation transaction
AppEntrypoint-->>Simulation: Return simulation result
Simulation-->>User: Provide simulation outcome
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
alpe
changed the title
alpe
changed the title
alpe
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (21)
x/staking/simulation/proposals.go (1)
44-44: Comment onMinCommissionRateorBondDenomchanges.The comment about
MinCommissionRateorBondDenomcreating issues for in-flight messages or state operations is crucial. Ensure this consideration is documented and communicated to developers.x/feegrant/simulation/operations.go (1)
145-145: Update the function call toSimulateMsgRevokeAllowancein tests/sims/feegrant/operations_test.go.The function call to
SimulateMsgRevokeAllowanceintests/sims/feegrant/operations_test.gostill usesapp.BaseAppinstead of the updatedsimtypes.AppEntrypoint. Please update the function call to match the new signature.
tests/sims/feegrant/operations_test.goline 10:operationMsg, futureOperations, err := op(r, app.BaseApp, ctx, accounts, "")Analysis chain
Verify the function usage in the codebase.
Ensure that all function calls to
SimulateMsgRevokeAllowancematch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgRevokeAllowance` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgRevokeAllowance'Length of output: 1893
x/authz/simulation/operations.go (2)
267-267: Mismatch in function signature usageThe function
SimulateMsgExechas been updated to usesimtypes.AppEntrypoint, but the following instances do not match the new signature:
x/group/simulation/operations_test.gox/group/simulation/operations.gox/authz/simulation/operations.gotests/sims/authz/operations_test.goPlease update these instances to match the new function signature.
Analysis chain
LGTM! But verify the function usage in the codebase.
The code changes are approved.
However, ensure that all function calls to
SimulateMsgExecmatch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgExec` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgExec'Length of output: 3366
186-186: Function calls toSimulateMsgRevokedo not match the new signature.The function calls to
SimulateMsgRevokestill use the old signature. Please update the following locations to match the new signature withsimtypes.AppEntrypoint:
x/authz/simulation/operations.gotests/sims/authz/operations_test.goAnalysis chain
LGTM! But verify the function usage in the codebase.
The code changes are approved.
However, ensure that all function calls to
SimulateMsgRevokematch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgRevoke` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgRevoke'Length of output: 3205
x/bank/simulation/operations.go (2)
65-65: Ensure all calls toSimulateMsgSendmatch the new signature.The code changes are approved, but there are still calls to
SimulateMsgSendwith the old signature in the following files:
x/bank/simulation/operations.gotests/sims/bank/operations_test.goPlease update these calls to match the new function signature.
Analysis chain
LGTM! But verify the function usage in the codebase.
The code changes are approved.
However, ensure that all function calls to
SimulateMsgSendmatch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgSend` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgSend'Length of output: 4987
112-112: The function call toSimulateMsgSendToModuleAccountin the test file does not match the new signature.Please update the function call in
tests/sims/bank/operations_test.goto include thesimtypes.AppEntrypointparameter.
tests/sims/bank/operations_test.go: Line 10Analysis chain
LGTM! But verify the function usage in the codebase.
The code changes are approved.
However, ensure that all function calls to
SimulateMsgSendToModuleAccountmatch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgSendToModuleAccount` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgSendToModuleAccount'Length of output: 1023
Script:
#!/bin/bash # Description: Extract the relevant lines from the test file to verify the function call matches the new signature. # Extract lines around the function call in the test file. rg -A 10 -B 10 'SimulateMsgSendToModuleAccount' tests/sims/bank/operations_test.goLength of output: 664
x/gov/simulation/operations.go (2)
503-503: Function signature mismatch detected!The usage of
operationSimulateMsgVoteWeighteddoes not match the new function signature. Ensure that all calls to this function are updated to match the new signature.
- File:
x/gov/simulation/operations.go- Line: 503
Analysis chain
LGTM! But verify the function usage in the codebase.
The function signature change is approved.
Ensure that all function calls to
operationSimulateMsgVoteWeightedmatch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `operationSimulateMsgVoteWeighted` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'operationSimulateMsgVoteWeighted'Length of output: 579
355-355: Update function calls to match the new signature.The function calls to
SimulateMsgDepositneed to be updated to match the new signature withsimtypes.AppEntrypoint.
x/gov/simulation/operations.go: Update the function call at line 355.tests/sims/gov/operations_test.go: Update the function call at line 355.Analysis chain
LGTM! But verify the function usage in the codebase.
The function signature change is approved.
Ensure that all function calls to
SimulateMsgDepositmatch the new signature.
Verify function usage matches the new signature.
The function signature change is approved. Ensure that all function calls to
SimulateMsgDepositmatch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgDeposit` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgDeposit'Length of output: 1926
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgDeposit` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 'SimulateMsgDeposit' | grep -E 'SimulateMsgDeposit\('Length of output: 456
x/staking/simulation/operations.go (1)
126-126: Ensure that all function calls toSimulateMsgCreateValidatormatch the new signature.The function calls in the following files need to be updated to match the new signature:
x/staking/simulation/operations.gotests/integration/staking/simulation/operations_test.goAnalysis chain
LGTM! But verify the function usage in the codebase.
The function signature change is approved.
Ensure that all function calls to
SimulateMsgCreateValidatormatch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgCreateValidator` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgCreateValidator'Length of output: 2382
Script:
#!/bin/bash # Description: Verify the function calls to `SimulateMsgCreateValidator` match the new signature. # Extract the lines where `SimulateMsgCreateValidator` is called in the identified files. rg --type go -A 5 'SimulateMsgCreateValidator' x/staking/simulation/operations.go tests/integration/staking/simulation/operations_test.goLength of output: 2473
x/group/simulation/operations.go (11)
252-252: Update test file to match new function signatureThe test file
x/group/simulation/operations_test.gostill referencessuite.app.BaseAppinstead ofsimtypes.AppEntrypoint. Please update the test cases to use the new interface.
- File:
x/group/simulation/operations_test.go- Lines:
operationMsg, futureOperations, err := op(r, suite.app.BaseApp, suite.ctx, accounts, "")(multiple occurrences)Analysis chain
Verify the usage of the new interface.
Ensure that
simtypes.AppEntrypointis correctly implemented and compatible with the existing logic.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgCreateGroup` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgCreateGroup'Length of output: 4587
536-536: Inconsistent function signature forSimulateMsgUpdateGroupAdmin.The function signature for
SimulateMsgUpdateGroupAdmininoperations.gostill uses*baseapp.BaseApp, whereas the test fileoperations_test.gouses the newsimtypes.AppEntrypoint. Please update the function signature inoperations.goto ensure consistency and compatibility.
operations.go: Update the function signature to usesimtypes.AppEntrypoint.Analysis chain
Verify the usage of the new interface.
Ensure that
simtypes.AppEntrypointis correctly implemented and compatible with the existing logic.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgUpdateGroupAdmin` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgUpdateGroupAdmin'Length of output: 1542
762-762: Inconsistent usage of the new interface in test fileThe test file
x/group/simulation/operations_test.gostill usessuite.app.BaseAppinstead of the updatedsimtypes.AppEntrypoint. Please update the test cases to ensure consistency with the new interface.
x/group/simulation/operations_test.go: Updatesuite.app.BaseApptosimtypes.AppEntrypoint.Analysis chain
Verify the usage of the new interface.
Ensure that
simtypes.AppEntrypointis correctly implemented and compatible with the existing logic.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgUpdateGroupPolicyAdmin` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgUpdateGroupPolicyAdmin'Length of output: 1610
610-610: Update function call to match new signature.The function call to
SimulateMsgUpdateGroupMetadatainx/group/simulation/operations_test.gostill usessuite.app.BaseApp. Please update it to use the new interfacesimtypes.AppEntrypoint.
x/group/simulation/operations_test.go: Replacesuite.app.BaseAppwith the appropriate implementation ofsimtypes.AppEntrypoint.Analysis chain
Verify the usage of the new interface.
Ensure that
simtypes.AppEntrypointis correctly implemented and compatible with the existing logic.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgUpdateGroupMetadata` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgUpdateGroupMetadata'Length of output: 1559
971-971: Potential mismatch in function call signature in test fileThe function
SimulateMsgWithdrawProposalhas been updated to usesimtypes.AppEntrypoint, but the test filex/group/simulation/operations_test.gostill usessuite.app.BaseApp. Please update the test file to match the new function signature.
x/group/simulation/operations_test.go: Updatesuite.app.BaseAppto usesimtypes.AppEntrypoint.Analysis chain
Verify the usage of the new interface.
Ensure that
simtypes.AppEntrypointis correctly implemented and compatible with the existing logic.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgWithdrawProposal` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgWithdrawProposal'Length of output: 1514
910-910: Update the test file to match the new function signature.The function
SimulateMsgUpdateGroupPolicyMetadatainoperations_test.gostill uses the old signature withsuite.app.BaseApp. Please update the test file to ensure it matches the new function signature withsimtypes.AppEntrypoint.
x/group/simulation/operations_test.go: Update the function call to usesimtypes.AppEntrypointinstead ofsuite.app.BaseApp.Analysis chain
Verify the usage of the new interface.
Ensure that
simtypes.AppEntrypointis correctly implemented and compatible with the existing logic.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgUpdateGroupPolicyMetadata` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgUpdateGroupPolicyMetadata'Length of output: 1592
377-377: Update function call to use the new interface.The function call to
SimulateMsgCreateGroupPolicyinx/group/simulation/operations_test.gostill usessuite.app.BaseApp. Update this to use the newsimtypes.AppEntrypointinterface to ensure consistency and compatibility.
- File: x/group/simulation/operations_test.go
- Lines:
operationMsg, futureOperations, err := op(r, suite.app.BaseApp, suite.ctx, accounts, "")Analysis chain
Verify the usage of the new interface.
Ensure that
simtypes.AppEntrypointis correctly implemented and compatible with the existing logic.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgCreateGroupPolicy` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgCreateGroupPolicy'Length of output: 1548
1200-1200: Update function calls to match the new signature.The function calls to
SimulateMsgExecstill use the old signature withsuite.app.BaseApp. Ensure all calls are updated to usesimtypes.AppEntrypoint.
x/group/simulation/operations_test.gotests/sims/authz/operations_test.goAnalysis chain
Verify the usage of the new interface.
Ensure that
simtypes.AppEntrypointis correctly implemented and compatible with the existing logic.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgExec` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgExec'Length of output: 3366
1285-1285: Inconsistent function signature usage in test file.The function
SimulateMsgLeaveGrouphas been updated to replace*baseapp.BaseAppwithsimtypes.AppEntrypoint. However, the test filex/group/simulation/operations_test.gostill referencessuite.app.BaseApp. Please update the test file to match the new function signature.
x/group/simulation/operations_test.goAnalysis chain
Verify the usage of the new interface.
Ensure that
simtypes.AppEntrypointis correctly implemented and compatible with the existing logic.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgLeaveGroup` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgLeaveGroup'Length of output: 1464
671-671: Update test cases to use the new interfacesimtypes.AppEntrypoint.The test cases in
operations_test.gostill usesuite.app.BaseAppinstead of the new interfacesimtypes.AppEntrypoint. Ensure that all test cases are updated to match the new function signature.
x/group/simulation/operations_test.go: Multiple instances wheresuite.app.BaseAppis used.Analysis chain
Verify the usage of the new interface.
Ensure that
simtypes.AppEntrypointis correctly implemented and compatible with the existing logic.
Verify the usage of the new interface
simtypes.AppEntrypointinSimulateMsgUpdateGroupMembersand its test cases.Ensure that
simtypes.AppEntrypointis correctly implemented and used in both the function and the test cases.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgUpdateGroupMembers` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgUpdateGroupMembers'Length of output: 1564
Script:
#!/bin/bash # Description: Verify the implementation and usage of `simtypes.AppEntrypoint`. # Search for the definition of `simtypes.AppEntrypoint`. rg --type go 'type AppEntrypoint' -A 5 # Verify if the test file `operations_test.go` has been updated to use `simtypes.AppEntrypoint`. rg --type go 'suite.app.BaseApp' -A 5Length of output: 18564
305-305: Verify the usage of the new interface.The transition from
*baseapp.BaseApptosimtypes.AppEntrypointis incomplete. The following files still contain references to*baseapp.BaseApp:
x/group/simulation/operations_test.gox/upgrade/types/storeloader_test.gox/upgrade/keeper/keeper_test.gox/upgrade/keeper/abci_test.gox/staking/keeper/keeper_test.gox/simulation/simulate.gox/consensus/depinject.gox/circuit/depinject.gox/authz/keeper/genesis_test.gox/authz/keeper/keeper_test.gox/auth/tx/config/depinject.gotestutil/sims/tx_helpers.gotestutil/integration/router.gotests/integration/bank/app_test.gotestutils/sims/runner.gosimapp/abci.goserver/util.gosimapp/sim_test.gosimapp/app_di.gosimapp/app.goruntime/module.goruntime/builder.goruntime/app.gobaseapp/utils_test.gobaseapp/baseapp_test.gobaseapp/streaming_test.gobaseapp/abci_test.goPlease ensure that all instances of
*baseapp.BaseAppare replaced withsimtypes.AppEntrypointto maintain consistency across the codebase.Analysis chain
Verify the usage of the new interface.
Ensure that
simtypes.AppEntrypointis correctly implemented and compatible with the existing logic.
Verify the usage of the new interface.
Ensure that all instances of
*baseapp.BaseApphave been replaced withsimtypes.AppEntrypointin the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgCreateGroupWithPolicy` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgCreateGroupWithPolicy'Length of output: 1484
Script:
#!/bin/bash # Description: Verify all instances of `*baseapp.BaseApp` have been replaced with `simtypes.AppEntrypoint`. # Test: Search for occurrences of `*baseapp.BaseApp`. Expect: No occurrences. rg --type go '\*baseapp.BaseApp'Length of output: 7821
CHANGELOG.md (1)
123-123: Surround lists with blank lines.To improve readability and comply with markdown linting rules, ensure that lists are surrounded by blank lines.
-### API Breaking Changes * (sims) [#21039](https://github.com/cosmos/cosmos-sdk/pull/21039): Remove Baseapp from sims by a new interface `simtypes.AppEntrypoint` * (client) [#20976](https://github.com/cosmos/cosmos-sdk/pull/20976) Simplified command initialization by removing unnecessary parameters such as `txConfig` and `addressCodec`. * Remove parameter `txConfig` from `genutilcli.Commands`,`genutilcli.CommandsWithCustomMigrationMap`,`genutilcli.GenTxCmd`. * Remove parameter `addressCodec` from `genutilcli.GenTxCmd`,`genutilcli.AddGenesisAccountCmd`,`stakingcli.BuildCreateValidatorMsg`. +Tools
Markdownlint
123-123: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (17)
- .gitignore (1 hunks)
- CHANGELOG.md (1 hunks)
- types/simulation/types.go (4 hunks)
- x/auth/simulation/proposals_test.go (1 hunks)
- x/authz/simulation/operations.go (4 hunks)
- x/bank/simulation/operations.go (7 hunks)
- x/distribution/simulation/operations.go (4 hunks)
- x/feegrant/simulation/operations.go (3 hunks)
- x/gov/simulation/operations.go (9 hunks)
- x/group/simulation/operations.go (15 hunks)
- x/nft/simulation/operations.go (2 hunks)
- x/protocolpool/simulation/operations.go (2 hunks)
- x/simulation/params.go (3 hunks)
- x/simulation/util.go (2 hunks)
- x/slashing/simulation/operations.go (2 hunks)
- x/staking/simulation/operations.go (8 hunks)
- x/staking/simulation/proposals.go (2 hunks)
Files skipped from review due to trivial changes (1)
- .gitignore
Additional context used
Path-based instructions (16)
x/auth/simulation/proposals_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"x/staking/simulation/proposals.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/protocolpool/simulation/operations.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/simulation/util.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/nft/simulation/operations.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/slashing/simulation/operations.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/feegrant/simulation/operations.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.types/simulation/types.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/simulation/params.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/distribution/simulation/operations.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/authz/simulation/operations.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/bank/simulation/operations.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/gov/simulation/operations.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/staking/simulation/operations.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/group/simulation/operations.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
golangci-lint
types/simulation/types.go
50-50: File is not
gofumpt-ed with-extra(gofumpt)
Markdownlint
CHANGELOG.md
123-123: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
Additional comments not posted (36)
x/auth/simulation/proposals_test.go (1)
35-35: Ensure the context is correctly initialized.The addition of
sdk.Context{}is crucial for the simulation. Verify that this context is correctly initialized and contains the necessary state for the simulation.x/staking/simulation/proposals.go (1)
44-44: Verify the impact of removing randomBondDenomgeneration.The removal of the random generation for
params.BondDenommight affect the variability in simulations. Ensure this change is intentional and does not negatively impact the simulation's effectiveness.x/protocolpool/simulation/operations.go (1)
49-49: Ensure the correct usage ofsimtypes.AppEntrypoint.The change from
*baseapp.BaseApptosimtypes.AppEntrypointneeds to be verified for correct usage. Ensure that all necessary methods and properties are accessible through the new interface.x/simulation/util.go (1)
67-67: Ensure correct usage ofsimtypes.AppEntrypoint.The
Appfield in theOperationInputstruct has been changed from*baseapp.BaseApptosimtypes.AppEntrypoint. Ensure that all interactions with this field are compatible with the new type.Verification successful
The usage of
simtypes.AppEntrypointis correct.The
Appfield in theOperationInputstruct is correctly used with thesimtypes.AppEntrypointtype, and theSimDelivermethod is appropriately called.
x/simulation/util.go: Verified the usage oftxCtx.App.SimDeliver.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the `App` field in the `OperationInput` struct. # Test: Search for the `App` field usage. Expect: Only occurances of the new type `simtypes.AppEntrypoint`. rg --type go -A 5 $'OperationInput'Length of output: 7745
Script:
#!/bin/bash # Description: Verify the usage of the `App` field in the `OperationInput` struct with the new type `simtypes.AppEntrypoint`. # Test: Search for the usage of the `App` field in the `OperationInput` struct. rg --type go 'txCtx.App' -A 5Length of output: 408
Script:
#!/bin/bash # Description: Verify the definition and methods of `simtypes.AppEntrypoint`, specifically looking for the `SimDeliver` method. # Test: Search for the definition of `simtypes.AppEntrypoint` and its methods. rg --type go 'type AppEntrypoint' -A 10 rg --type go 'func (a AppEntrypoint)' -A 10Length of output: 840
x/nft/simulation/operations.go (1)
63-63: Ensure correct usage ofsimtypes.AppEntrypoint.The
appparameter in theSimulateMsgSendfunction has been changed from*baseapp.BaseApptosimtypes.AppEntrypoint. Ensure that all interactions with this parameter are compatible with the new type.x/slashing/simulation/operations.go (1)
61-61: Ensure correct usage ofsimtypes.AppEntrypoint.The
appparameter in theSimulateMsgUnjailfunction has been changed from*baseapp.BaseApptosimtypes.AppEntrypoint. Ensure that all interactions with this parameter are compatible with the new type.x/feegrant/simulation/operations.go (1)
81-81: Verify the function usage in the codebase.Ensure that all function calls to
SimulateMsgGrantAllowancematch the new signature.Verification successful
Verify all function calls to
SimulateMsgGrantAllowancematch the new signature.Ensure that all occurrences of
SimulateMsgGrantAllowancein the codebase use the new signature.
Verification successful.
All occurrences of
SimulateMsgGrantAllowancein the codebase match the new signature.
x/feegrant/simulation/operations.gotests/sims/feegrant/operations_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgGrantAllowance` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgGrantAllowance'Length of output: 1973
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgGrantAllowance` match the new signature. # Test: Search for all occurrences of the function usage. Expect: Only occurrences of the new signature. rg --type go 'SimulateMsgGrantAllowance' -A 5Length of output: 1973
types/simulation/types.go (4)
18-21: LGTM!The new
AppEntrypointinterface is well-defined and aligns with the goal of decoupling the simulation framework from theBaseAppimplementation.
44-46: LGTM!The updates to the
WeightedProposalMsginterface enhance the flexibility of the message simulation process by allowing for a context-aware simulator function.
49-51: LGTM!The update to the
MsgSimulatorFntype allows for better management of request contexts during message simulation.Tools
golangci-lint
50-50: File is not
gofumpt-ed with-extra(gofumpt)
76-76: LGTM!The update to the
Operationtype aligns with the goal of decoupling the simulation framework from theBaseAppimplementation and allows for greater flexibility in how operations interact with the application entry point.x/simulation/params.go (3)
4-4: LGTM!The addition of the
contextpackage is necessary for the new function's signature and aligns with best practices for context management.
131-133: LGTM!The changes to the
WeightedProposalMsgstruct enhance the flexibility of the message simulation process by allowing for a context-aware simulator function.
143-144: LGTM!The new
NewWeightedProposalMsgXfunction ensures backward compatibility while encouraging the use of the updated functionality.x/distribution/simulation/operations.go (3)
76-76: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
SimulateMsgSetWithdrawAddressmatch the new signature.Verification successful
Verified: All function calls to
SimulateMsgSetWithdrawAddressmatch the new signature.
x/distribution/simulation/operations.gotests/sims/distribution/operations_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgSetWithdrawAddress` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgSetWithdrawAddress'Length of output: 2578
125-125: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
SimulateMsgWithdrawDelegatorRewardmatch the new signature.Verification successful
Function usage matches the new signature.
The function
SimulateMsgWithdrawDelegatorRewardhas been updated and all instances in the codebase reflect the new signature.
x/distribution/simulation/operations.gotests/sims/distribution/operations_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgWithdrawDelegatorReward` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgWithdrawDelegatorReward'Length of output: 2774
193-193: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
SimulateMsgWithdrawValidatorCommissionmatch the new signature.Verification successful
Verified: Function usage matches the new signature.
The function
SimulateMsgWithdrawValidatorCommissionhas been correctly updated, and all usages align with the new signature.
x/distribution/simulation/operations.gotests/sims/distribution/operations_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgWithdrawValidatorCommission` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgWithdrawValidatorCommission'Length of output: 3267
x/authz/simulation/operations.go (1)
105-105: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
SimulateMsgGrantmatch the new signature.x/bank/simulation/operations.go (4)
148-148: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
sendMsgSendmatch the new signature.Verification successful
Verified: All function calls to
sendMsgSendmatch the new signature.The function
sendMsgSendhas been correctly updated in all instances found in the codebase.
x/bank/simulation/operations.go: Lines 148 and other instances in the same file.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `sendMsgSend` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'sendMsgSend'Length of output: 1514
200-200: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
SimulateMsgMultiSendmatch the new signature.
372-372: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
sendMsgMultiSendmatch the new signature.
304-304: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
SimulateMsgMultiSendToModuleAccountmatch the new signature.Verification successful
The function usage matches the new signature.
The function
SimulateMsgMultiSendToModuleAccountis used correctly in the test filetests/sims/bank/operations_test.gowith the updated signature.
tests/sims/bank/operations_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgMultiSendToModuleAccount` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgMultiSendToModuleAccount'Length of output: 1373
x/gov/simulation/operations.go (5)
173-173: LGTM! But verify the function usage in the codebase.The function signature change is approved.
Ensure that all function calls to
SimulateMsgSubmitProposalmatch the new signature.Verification successful
Ensure all instances of
SimulateMsgSubmitProposalmatch the new signature.The function signature change is approved. Verify that all instances of
SimulateMsgSubmitProposalacross the codebase match the new signature.
x/group/simulation/operations_test.gox/group/simulation/operations.gox/gov/simulation/operations.gotests/sims/gov/operations_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgSubmitProposal` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgSubmitProposal'Length of output: 3585
251-251: LGTM! But verify the function usage in the codebase.The function signature change is approved.
Ensure that all function calls to
simulateMsgSubmitProposalmatch the new signature.
434-434: LGTM! But verify the function usage in the codebase.The function signature change is approved.
Ensure that all function calls to
operationSimulateMsgVotematch the new signature.
200-200: LGTM! But verify the function usage in the codebase.The function signature change is approved.
Ensure that all function calls to
SimulateMsgSubmitLegacyProposalmatch the new signature.Verification successful
LGTM! The function usage matches the new signature.
The function signature change is correctly reflected in both the main code and the test cases.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgSubmitLegacyProposal` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgSubmitLegacyProposal'Length of output: 2252
Script:
#!/bin/bash # Verify the usage of SimulateMsgSubmitLegacyProposal in x/gov/simulation/operations.go and tests/sims/gov/operations_test.go # Check the usage in x/gov/simulation/operations.go rg --type go -A 5 'SimulateMsgSubmitLegacyProposal' x/gov/simulation/operations.go # Check the usage in tests/sims/gov/operations_test.go rg --type go -A 5 'SimulateMsgSubmitLegacyProposal' tests/sims/gov/operations_test.goLength of output: 1425
329-339: Verify the impact of deactivating future operations.The future operations have been deactivated, which may affect the simulation process.
x/staking/simulation/operations.go (6)
310-310: LGTM! But verify the function usage in the codebase.The function signature change is approved.
Ensure that all function calls to
SimulateMsgDelegatematch the new signature.Verification successful
Verified: All function calls to
SimulateMsgDelegatematch the new signature.The function signature change is correctly reflected in the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgDelegate` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgDelegate'Length of output: 2299
615-615: LGTM! But verify the function usage in the codebase.The function signature change is approved.
Ensure that all function calls to
SimulateMsgBeginRedelegatematch the new signature.
392-392: LGTM! But verify the function usage in the codebase.The function signature change is approved.
Ensure that all function calls to
SimulateMsgUndelegatematch the new signature.
759-759: LGTM! But verify the function usage in the codebase.The function signature change is approved.
Ensure that all function calls to
SimulateMsgRotateConsPubKeymatch the new signature.Verification successful
Verified: All function calls to
SimulateMsgRotateConsPubKeymatch the new signature.
x/staking/simulation/operations.gotests/integration/staking/simulation/operations_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgRotateConsPubKey` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgRotateConsPubKey'Length of output: 1624
235-235: LGTM! But verify the function usage in the codebase.The function signature change is approved.
Ensure that all function calls to
SimulateMsgEditValidatormatch the new signature.Verification successful
Verify the function usage in the codebase.
The function signature change is approved. Ensure that all function calls to
SimulateMsgEditValidatormatch the new signature.
x/staking/simulation/operations.gotests/integration/staking/simulation/operations_test.go
All function calls to
SimulateMsgEditValidatormatch the new signature.
x/staking/simulation/operations.gotests/integration/staking/simulation/operations_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgEditValidator` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgEditValidator'Length of output: 2357
Script:
#!/bin/bash # Verify function calls in `x/staking/simulation/operations.go` rg --type go -A 5 'SimulateMsgEditValidator' x/staking/simulation/operations.go # Verify function calls in `tests/integration/staking/simulation/operations_test.go` rg --type go -A 5 'SimulateMsgEditValidator' tests/integration/staking/simulation/operations_test.goLength of output: 1251
511-511: LGTM! But verify the function usage in the codebase.The function signature change is approved.
Ensure that all function calls to
SimulateMsgCancelUnbondingDelegatematch the new signature.x/group/simulation/operations.go (3)
836-836: Verify the usage of the new interface.Ensure that
simtypes.AppEntrypointis correctly implemented and compatible with the existing logic.Verification successful
Verify the usage of the new interface.
Ensure that
simtypes.AppEntrypointis correctly implemented and compatible with the existing logic.
- The function
SimulateMsgUpdateGroupPolicyDecisionPolicyhas been updated to usesimtypes.AppEntrypoint.- The search results show that the function is invoked with the new parameter in
x/group/simulation/operations_test.go.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgUpdateGroupPolicyDecisionPolicy` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgUpdateGroupPolicyDecisionPolicy'Length of output: 1667
1087-1087: Verify the usage of the new interface.Ensure that
simtypes.AppEntrypointis correctly implemented and compatible with the existing logic.
449-449: Verify the usage of the new interface.Ensure that
simtypes.AppEntrypointis correctly implemented and compatible with the existing logic.
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
CHANGELOG.md (1)
123-123: Fix formatting: Surround lists by blank lines.To comply with Markdown best practices, lists should be surrounded by blank lines.
### API Breaking Changes * (sims) [#21039](https://github.com/cosmos/cosmos-sdk/pull/21039): Remove Baseapp from sims by a new interface `simtypes.AppEntrypoint` * (client) [#20976](https://github.com/cosmos/cosmos-sdk/pull/20976) Simplified command initialization by removing unnecessary parameters such as `txConfig` and `addressCodec`. * Remove parameter `txConfig` from `genutilcli.Commands`,`genutilcli.CommandsWithCustomMigrationMap`,`genutilcli.GenTxCmd`. * Remove parameter `addressCodec` from `genutilcli.GenTxCmd`,`genutilcli.AddGenesisAccountCmd`,`stakingcli.BuildCreateValidatorMsg`.Tools
Markdownlint
123-123: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (18)
- .gitignore (1 hunks)
- CHANGELOG.md (1 hunks)
- types/simulation/types.go (4 hunks)
- x/auth/simulation/proposals_test.go (1 hunks)
- x/authz/simulation/operations.go (4 hunks)
- x/bank/simulation/operations.go (7 hunks)
- x/distribution/simulation/operations.go (4 hunks)
- x/feegrant/simulation/operations.go (3 hunks)
- x/gov/simulation/operations.go (9 hunks)
- x/gov/simulation/proposals.go (1 hunks)
- x/group/simulation/operations.go (15 hunks)
- x/nft/simulation/operations.go (2 hunks)
- x/protocolpool/simulation/operations.go (2 hunks)
- x/simulation/params.go (3 hunks)
- x/simulation/util.go (2 hunks)
- x/slashing/simulation/operations.go (2 hunks)
- x/staking/simulation/operations.go (8 hunks)
- x/staking/simulation/proposals.go (2 hunks)
Files skipped from review due to trivial changes (3)
- x/authz/simulation/operations.go
- x/bank/simulation/operations.go
- x/gov/simulation/proposals.go
Files skipped from review as they are similar to previous changes (12)
- .gitignore
- x/auth/simulation/proposals_test.go
- x/distribution/simulation/operations.go
- x/feegrant/simulation/operations.go
- x/gov/simulation/operations.go
- x/group/simulation/operations.go
- x/nft/simulation/operations.go
- x/protocolpool/simulation/operations.go
- x/simulation/params.go
- x/slashing/simulation/operations.go
- x/staking/simulation/operations.go
- x/staking/simulation/proposals.go
Additional context used
Path-based instructions (3)
x/simulation/util.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.types/simulation/types.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
golangci-lint
types/simulation/types.go
50-50: File is not
gofumpt-ed with-extra(gofumpt)
Markdownlint
CHANGELOG.md
123-123: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
Additional comments not posted (5)
x/simulation/util.go (1)
67-67: Change inAppfield type inOperationInputstruct.The type of the
Appfield has been changed from*baseapp.BaseApptosimtypes.AppEntrypoint. This change decouples the simulation framework from the specific implementation ofBaseApp, enhancing modularity and flexibility.types/simulation/types.go (4)
18-21: Introduction ofAppEntrypointinterface.The
AppEntrypointinterface defines a method for delivering simulation transactions to the app. This abstraction allows for greater flexibility in how operations interact with the application, enhancing modularity and maintainability.
44-46: Update toWeightedProposalMsginterface.The
WeightedProposalMsginterface has been updated to change the type of theMsgSimulatorFnmethod fromMsgSimulatorFntoMsgSimulatorFnX. This change reflects a shift towards a more structured approach for message simulation, incorporating context management.
51-51: Introduction ofMsgSimulatorFnXtype.The
MsgSimulatorFnXtype includes acontext.Contextparameter, allowing for better management of request contexts during message simulation. This aligns with best practices for context management.
76-76: Change inOperationtype.The
Operationtype has been modified to accept anAppEntrypointinstead of thebaseapp.BaseApp. This change reinforces the new structure, allowing for greater flexibility in how operations interact with the application entry point.
tac0turtle
added
the
backport/v0.52.x
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (2)
x/gov/simulation/proposals_test.go (1)
34-34: Inconsistent usage ofcontext.Background()inTestProposalMsgsfunctions.The
TestProposalMsgsfunction inx/gov/simulation/proposals_test.gohas been updated to include acontext.Background()argument. However, this update is not reflected in other packages whereTestProposalMsgsis defined. To ensure consistency and proper context management, please update the following instances:
x/slashing/simulation/proposals_test.gox/staking/simulation/proposals_test.gox/protocolpool/simulation/proposals_test.gox/mint/simulation/proposals_test.gox/distribution/simulation/proposals_test.gox/bank/simulation/proposals_test.gox/auth/simulation/proposals_test.goAnalysis chain
Context parameter added to
TestProposalMsgs.The function
TestProposalMsgsnow includes acontext.Background()argument, enhancing context management.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `TestProposalMsgs` in the codebase. # Test: Search for the usage of `TestProposalMsgs`. Expect: Only occurrences of the updated function. rg --type go -A 5 $'TestProposalMsgs'Length of output: 3276
tests/sims/gov/operations_test.go (1)
60-61: Update all occurrences ofMsgSimulatorFntoMsgSimulatorFnX.The following locations still use the old function signature
MsgSimulatorFnand need to be updated toMsgSimulatorFnX:
x/simulation/params.go: func NewWeightedProposalMsg(appParamsKey string, defaultWeight int, msgSimulatorFn simulation.MsgSimulatorFn) simulation.WeightedProposalMsgtypes/simulation/types.go: MsgSimulatorFn() MsgSimulatorFnX // msg simulator functiontypes/simulation/types.go: MsgSimulatorFn func(r *rand.Rand, accs []Account, cdc address.Codec) (sdk.Msg, error)Please update these references to use
MsgSimulatorFnXinstead.Analysis chain
LGTM! But verify the function usage in the codebase.
The code changes are approved.
However, ensure that all function calls to
MsgSimulatorFnandMsgSimulatorFnXare updated and used correctly in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `MsgSimulatorFn` and `MsgSimulatorFnX` in the codebase. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'MsgSimulatorFn' rg --type go -A 5 $'MsgSimulatorFnX'Length of output: 11351
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (17)
- tests/sims/gov/operations_test.go (2 hunks)
- types/simulation/types.go (4 hunks)
- x/auth/simulation/proposals.go (3 hunks)
- x/bank/simulation/proposals.go (3 hunks)
- x/bank/simulation/proposals_test.go (2 hunks)
- x/distribution/simulation/proposals.go (3 hunks)
- x/distribution/simulation/proposals_test.go (2 hunks)
- x/gov/simulation/proposals.go (3 hunks)
- x/gov/simulation/proposals_test.go (2 hunks)
- x/mint/simulation/proposals.go (3 hunks)
- x/mint/simulation/proposals_test.go (2 hunks)
- x/protocolpool/simulation/proposals.go (2 hunks)
- x/protocolpool/simulation/proposals_test.go (2 hunks)
- x/slashing/simulation/proposals.go (3 hunks)
- x/slashing/simulation/proposals_test.go (2 hunks)
- x/staking/simulation/proposals.go (3 hunks)
- x/staking/simulation/proposals_test.go (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- x/staking/simulation/proposals.go
Additional context used
Path-based instructions (16)
x/bank/simulation/proposals.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/bank/simulation/proposals_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"x/distribution/simulation/proposals.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/protocolpool/simulation/proposals.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/distribution/simulation/proposals_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"x/protocolpool/simulation/proposals_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"x/auth/simulation/proposals.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/staking/simulation/proposals_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"x/gov/simulation/proposals.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/slashing/simulation/proposals_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"x/mint/simulation/proposals_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"x/slashing/simulation/proposals.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/mint/simulation/proposals.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.types/simulation/types.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/gov/simulation/proposals_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"tests/sims/gov/operations_test.go (3)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
Additional comments not posted (28)
x/bank/simulation/proposals.go (2)
26-29: Change to useNewWeightedProposalMsgXlooks good.The update to use
simulation.NewWeightedProposalMsgXinstead ofsimulation.NewWeightedProposalMsgis approved. Ensure that the new functionNewWeightedProposalMsgXis well-tested and documented.
Line range hint
35-48:
Change to includecontext.Contextparameter looks good.The update to include
context.Contextin the function signature enhances context management.Ensure that all calls to
SimulateMsgUpdateParamsare updated to pass the newcontext.Contextparameter.x/bank/simulation/proposals_test.go (1)
37-37: Change to includecontext.Background()in test looks good.The update to include
context.Background()in theMsgSimulatorFninvocation aligns with the updated function signature for context management.x/distribution/simulation/proposals.go (2)
27-30: Change to useNewWeightedProposalMsgXlooks good.The update to use
simulation.NewWeightedProposalMsgXinstead ofsimulation.NewWeightedProposalMsgis approved. Ensure that the new functionNewWeightedProposalMsgXis well-tested and documented.
Line range hint
36-49:
Change to includecontext.Contextparameter looks good.The update to include
context.Contextin the function signature enhances context management.Ensure that all calls to
SimulateMsgUpdateParamsare updated to pass the newcontext.Contextparameter.x/protocolpool/simulation/proposals.go (3)
4-4: Import statement forcontextis appropriate.The addition of
contextis necessary for the updated function signatures.
32-32: Ensure proper error handling and context usage.The function logic appears correct and includes proper error handling. Ensure that the context is used appropriately in the calling code.
24-27: LGTM! But verify the function usage in the codebase.The changes to use
NewWeightedProposalMsgXand includecontext.Contextare approved.However, ensure that all function calls to
SimulateMsgCommunityPoolSpendmatch the new signature.Verification successful
Verified: Function usage is correct.
The function
SimulateMsgCommunityPoolSpendis used correctly with the updated signature in the codebase. No other occurrences were found.
x/protocolpool/simulation/proposals.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgCommunityPoolSpend` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SimulateMsgCommunityPoolSpend'Length of output: 848
Script:
#!/bin/bash # Description: Verify all function calls to `SimulateMsgCommunityPoolSpend` match the new signature across the entire codebase. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go 'SimulateMsgCommunityPoolSpend'Length of output: 288
x/distribution/simulation/proposals_test.go (2)
4-4: Import statement forcontextis appropriate.The addition of
contextis necessary for the updated test function.
37-37: LGTM! The addition ofcontext.Background()is appropriate.The change to include
context.Background()in the function call is approved.x/protocolpool/simulation/proposals_test.go (2)
4-4: Import statement forcontextis appropriate.The addition of
contextis necessary for the updated test function.
36-36: LGTM! The addition ofcontext.Background()is appropriate.The change to include
context.Background()in the function call is approved.x/auth/simulation/proposals.go (2)
26-29: Verify the purpose and impact of usingsimulation.NewWeightedProposalMsgX.Ensure that the change to
simulation.NewWeightedProposalMsgXis intentional and understand the differences and benefits compared tosimulation.NewWeightedProposalMsg.
35-35: LGTM! Ensure proper usage ofcontext.Context.The addition of
context.Contextis a good practice for managing cancellations and deadlines.Verify that the context parameter is used appropriately within the function and its callers.
x/staking/simulation/proposals_test.go (2)
4-4: LGTM! Ensure proper usage ofcontext.Context.The addition of
context.Contextis a good practice for managing cancellations and deadlines.Verify that the context parameter is used appropriately within the function and its callers.
44-48: Verify the correctness of updated staking parameters.Ensure that the new values for
BondDenom,MaxEntries,HistoricalEntries,MaxValidators, andUnbondingTimeare correct and align with the expected configuration.x/gov/simulation/proposals.go (2)
21-24: Verify the purpose and impact of usingsimulation.NewWeightedProposalMsgX.Ensure that the change to
simulation.NewWeightedProposalMsgXis intentional and understand the differences and benefits compared tosimulation.NewWeightedProposalMsg.
31-31: LGTM! Ensure proper usage ofcontext.Context.The addition of
context.Contextis a good practice for managing cancellations and deadlines.Verify that the context parameter is used appropriately within the function and its callers.
x/slashing/simulation/proposals_test.go (1)
4-4: LGTM! The addition of context is appropriate.The addition of
context.Background()to theMsgSimulatorFncall is a good practice for handling context-aware operations.Also applies to: 38-38
x/mint/simulation/proposals_test.go (1)
4-4: LGTM! The addition of context is appropriate.The addition of
context.Background()to theMsgSimulatorFncall is a good practice for handling context-aware operations.Also applies to: 37-37
x/slashing/simulation/proposals.go (2)
4-4: LGTM! The use ofNewWeightedProposalMsgXis appropriate.The change to use
simulation.NewWeightedProposalMsgXindicates a potential update in how weighted proposal messages are constructed.Also applies to: 28-31
37-37: LGTM! The addition of context is appropriate.The addition of
context.Contextto the function signature is a good practice for handling context-aware operations.x/mint/simulation/proposals.go (2)
36-36: LGTM! Verify the function usage in the codebase.The function
SimulateMsgUpdateParamsnow includes acontext.Contextparameter. Ensure that all calls to this function pass the appropriate context.
27-30: LGTM! Verify the function usage in the codebase.The function
NewWeightedProposalMsgXis used correctly. Ensure that this function exists and is used appropriately throughout the codebase.Verification successful
Verified the function usage in the codebase.
The function
NewWeightedProposalMsgXis correctly used and implemented across multiple files in the codebase. The definition inx/simulation/params.goand its usage in other files confirm its proper application.
x/simulation/params.go: Function definition and usage.- Other files (e.g.,
x/mint/simulation/proposals.go,x/staking/simulation/proposals.go, etc.): Correct usage.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `NewWeightedProposalMsgX` in the codebase. # Test: Search for the function usage. Expect: Only occurrences of the new function. rg --type go -A 5 $'NewWeightedProposalMsgX'Length of output: 3828
types/simulation/types.go (4)
4-4: Context package imported.The
contextpackage is imported to support the addition ofcontext.Contextparameters in function signatures.
18-21: AppEntrypoint interface introduced.The
AppEntrypointinterface defines a method for delivering simulation transactions to the app, replacing*baseapp.BaseApp.
78-80: Operation type updated.The
Operationtype now accepts anAppEntrypointinstead of*baseapp.BaseApp, enhancing modularity and flexibility.Verification successful
Operation type updated.
The
Operationtype now accepts anAppEntrypointinstead of*baseapp.BaseApp, enhancing modularity and flexibility.
- Verified that the changes have been correctly applied across the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `Operation` type in the codebase. # Test: Search for the usage of `Operation` type. Expect: Only occurrences of the updated type. rg --type go -A 5 $'Operation'Length of output: 161805
44-46: WeightedProposalMsg interface updated.The
WeightedProposalMsginterface now usesMsgSimulatorFnX, reflecting the updated function signature withcontext.Context.Verification successful
WeightedProposalMsg interface updated and used correctly.
The
WeightedProposalMsginterface has been updated to useMsgSimulatorFnX, and this change is consistently reflected across the codebase.
x/staking/simulation/proposals.gox/slashing/simulation/proposals.gox/mint/simulation/proposals.gox/distribution/simulation/proposals.gox/protocolpool/simulation/proposals.gox/gov/simulation/proposals.gox/bank/simulation/proposals.gox/auth/simulation/proposals.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `WeightedProposalMsg` in the codebase. # Test: Search for the usage of `WeightedProposalMsg`. Expect: Only occurrences of the updated interface. rg --type go -A 5 $'WeightedProposalMsg'Length of output: 13263
github-actions
bot
added
C:x/accounts
C:x/accounts/lockup
C:server/v2
C:server/v2 cometbft
labels
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (7)
server/v2/cometbft/go.mod (7)
The dependency
github.com/cosmos/gogogatewayis still being used in the codebase.The following files import
github.com/cosmos/gogogateway:
server/v2/api/grpcgateway/server.goserver/api/server.goPlease ensure that these imports are removed or replaced before deleting the dependency from
go.mod.Analysis chain
Line range hint
1-12:
Verify removal ofgithub.com/cosmos/gogogateway.Ensure that
github.com/cosmos/gogogatewayis no longer used in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if `github.com/cosmos/gogogateway` is no longer used in the codebase. # Test: Search for any usage of `github.com/cosmos/gogogateway`. Expect: No matches. rg --type go 'github.com/cosmos/gogogateway'Length of output: 183
Dependency
github.com/huandu/skiplistis still in use.The dependency
github.com/huandu/skiplisthas been removed fromgo.mod, but it is still being used in the following files:
types/mempool/skip_list_test.gotypes/mempool/sender_nonce.gotypes/mempool/priority_nonce.goPlease ensure that all usages of this dependency are removed or replaced before removing it from
go.mod.Analysis chain
Line range hint
1-12:
Verify removal ofgithub.com/huandu/skiplist.Ensure that
github.com/huandu/skiplistis no longer used in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if `github.com/huandu/skiplist` is no longer used in the codebase. # Test: Search for any usage of `github.com/huandu/skiplist`. Expect: No matches. rg --type go 'github.com/huandu/skiplist'Length of output: 225
The dependency
github.com/gorilla/mux v1.8.1is still being used in the codebase.Please review the following files and remove or replace the usage of
github.com/gorilla/muxif it is no longer necessary:
server/v2/api/telemetry/server.goserver/swagger.goserver/v2/api/grpcgateway/server.goserver/api/server.goAnalysis chain
Line range hint
1-12:
Verify removal ofgithub.com/gorilla/mux.Ensure that
github.com/gorilla/muxis no longer used in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if `github.com/gorilla/mux` is no longer used in the codebase. # Test: Search for any usage of `github.com/gorilla/mux`. Expect: No matches. rg --type go 'github.com/gorilla/mux'Length of output: 250
Issue Found: Dependency
cosmossdk.io/schema v0.1.1is still in use.The dependency
cosmossdk.io/schema v0.1.1is still being referenced in multiple files across the codebase. Removing it from thego.modfile is likely to cause build failures or runtime errors. Please ensure that all references tocosmossdk.io/schemaare removed or update thego.modfile to include this dependency.
- Files with references:
schema/appdata/data.goschema/indexer/indexer.goschema/indexer/manager.goschema/decoding/sync.goschema/decoding/middleware.goschema/decoding/resolver_test.goschema/decoding/resolver.goschema/decoding/decoding_test.goindexer/postgres/column.goindexer/postgres/object.goindexer/postgres/module.goindexer/postgres/enum.goindexer/postgres/indexer.goindexer/postgres/tests/init_schema_test.goindexer/postgres/create_table_test.goindexer/postgres/internal/testdata/example_schema.gobaseapp/streaming.goAnalysis chain
Line range hint
1-12:
Verify removal ofcosmossdk.io/schema.Ensure that
cosmossdk.io/schemais no longer used in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if `cosmossdk.io/schema` is no longer used in the codebase. # Test: Search for any usage of `cosmossdk.io/schema`. Expect: No matches. rg --type go 'cosmossdk.io/schema'Length of output: 1484
Dependency
github.com/gogo/googleapis v1.4.1is still present.The dependency
github.com/gogo/googleapis v1.4.1has not been fully removed from the codebase. It is still referenced in multiplego.modandgo.sumfiles.
x/group/go.modx/upgrade/go.modx/slashing/go.modx/staking/go.modx/mint/go.modx/params/go.modx/nft/go.modx/protocolpool/go.modx/epochs/go.modx/evidence/go.modx/feegrant/go.modx/gov/go.modx/distribution/go.modx/consensus/go.modx/authz/go.modx/bank/go.modx/circuit/go.modtools/confix/go.modtools/cosmovisor/go.modtools/hubl/go.modx/accounts/defaults/multisig/go.modx/accounts/go.modx/auth/go.modtests/systemtests/go.modsimapp/v2/go.modsimapp/go.modserver/v2/go.modserver/v2/cometbft/go.sumclient/v2/go.modgo.modPlease ensure that all references to
github.com/gogo/googleapis v1.4.1are removed from the codebase.Analysis chain
Line range hint
1-12:
Verify removal ofgithub.com/gogo/googleapis.Ensure that
github.com/gogo/googleapisis no longer used in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if `github.com/gogo/googleapis` is no longer used in the codebase. # Test: Search for any usage of `github.com/gogo/googleapis`. Expect: No matches. rg --type go 'github.com/gogo/googleapis'Length of output: 41
Script:
#!/bin/bash # Description: Verify if `github.com/gogo/googleapis` is no longer used in the codebase. # Test: Search for any usage of `github.com/gogo/googleapis`. Expect: No matches. rg 'github.com/gogo/googleapis'Length of output: 13201
Dependency
github.com/felixge/httpsnoopis still present.The dependency
github.com/felixge/httpsnoop v1.0.4is still present in variousgo.modandgo.sumfiles across the codebase, indicating that it has not been fully removed.
x/upgrade/go.modx/nft/go.sumx/nft/go.modx/upgrade/go.sumx/staking/go.modx/staking/go.sumx/slashing/go.sumx/slashing/go.modx/params/go.sumx/params/go.modx/protocolpool/go.modx/protocolpool/go.sumx/group/go.sumx/group/go.modx/mint/go.modx/mint/go.sumx/gov/go.sumx/gov/go.modx/feegrant/go.sumx/feegrant/go.modx/evidence/go.modx/evidence/go.sumx/epochs/go.modx/distribution/go.modx/epochs/go.sumx/consensus/go.modx/consensus/go.sumx/distribution/go.sumx/bank/go.sumx/bank/go.modx/circuit/go.modx/circuit/go.sumx/authz/go.sumx/authz/go.modx/accounts/go.sumx/accounts/go.modx/auth/go.modx/auth/go.sumx/accounts/defaults/multisig/go.modx/accounts/defaults/multisig/go.sumx/accounts/defaults/lockup/go.sumtools/hubl/go.modtools/hubl/go.sumtools/cosmovisor/go.sumtools/cosmovisor/go.modtools/confix/go.modtools/confix/go.sumtests/systemtests/go.modtests/systemtests/go.sumtests/go.modtests/go.sumsimapp/go.modsimapp/go.sumserver/v2/cometbft/go.sumsimapp/v2/go.modsimapp/v2/go.sumgo.modgo.sumclient/v2/go.modclient/v2/go.sumAnalysis chain
Line range hint
1-12:
Verify removal ofgithub.com/felixge/httpsnoop.Ensure that
github.com/felixge/httpsnoopis no longer used in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if `github.com/felixge/httpsnoop` is no longer used in the codebase. # Test: Search for any usage of `github.com/felixge/httpsnoop`. Expect: No matches. rg --type go 'github.com/felixge/httpsnoop'Length of output: 43
Script:
#!/bin/bash # Description: Verify if `github.com/felixge/httpsnoop` is present in any go.mod or go.sum files. # Search for `github.com/felixge/httpsnoop` in all go.mod and go.sum files. rg 'github.com/felixge/httpsnoop' --glob '**/go.mod' --glob '**/go.sum'Length of output: 8674
The dependency
github.com/grpc-ecosystem/go-grpc-middleware v1.4.0is still in use.The imports and their usage in
baseapp/grpcserver.goconfirm thatgrpcmiddlewareandgrpcrecoveryare actively utilized in the code.
baseapp/grpcserver.go:
grpcmiddlewareis used in a method handler.grpcrecoveryis used as a unary server interceptor.Please ensure that the dependency is not removed from
go.modunless these usages are refactored or removed.Analysis chain
Line range hint
1-12:
Verify removal ofgithub.com/grpc-ecosystem/go-grpc-middleware.Ensure that
github.com/grpc-ecosystem/go-grpc-middlewareis no longer used in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if `github.com/grpc-ecosystem/go-grpc-middleware` is no longer used in the codebase. # Test: Search for any usage of `github.com/grpc-ecosystem/go-grpc-middleware`. Expect: No matches. rg --type go 'github.com/grpc-ecosystem/go-grpc-middleware'Length of output: 236
Script:
#!/bin/bash # Description: Extract relevant lines around the import statements in baseapp/grpcserver.go to confirm if `github.com/grpc-ecosystem/go-grpc-middleware` is still in use. # Extract lines around the import statements to understand the context. rg --type go --context 5 'github.com/grpc-ecosystem/go-grpc-middleware' baseapp/grpcserver.goLength of output: 428
Script:
#!/bin/bash # Description: Search for the usage of `grpcmiddleware` and `grpcrecovery` in baseapp/grpcserver.go to confirm if `github.com/grpc-ecosystem/go-grpc-middleware` is still in use. # Search for `grpcmiddleware` usage. rg --type go 'grpcmiddleware' baseapp/grpcserver.go # Search for `grpcrecovery` usage. rg --type go 'grpcrecovery' baseapp/grpcserver.goLength of output: 353
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (2)
server/v2/cometbft/go.sumis excluded by!**/*.sumx/accounts/defaults/lockup/go.sumis excluded by!**/*.sum
Files selected for processing (2)
- server/v2/cometbft/go.mod (7 hunks)
- x/accounts/defaults/lockup/go.mod (6 hunks)
Files skipped from review due to trivial changes (1)
- x/accounts/defaults/lockup/go.mod
Additional comments not posted (5)
server/v2/cometbft/go.mod (5)
Line range hint
1-12:
Verify removal ofgithub.com/Microsoft/go-winio.Ensure that
github.com/Microsoft/go-winiois no longer used in the codebase.Verification successful
Verified removal of
github.com/Microsoft/go-winio.The search for
github.com/Microsoft/go-winioin the codebase did not produce any matches, indicating that the dependency has been successfully removed.
- Dependency
github.com/Microsoft/go-winiois no longer used in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if `github.com/Microsoft/go-winio` is no longer used in the codebase. # Test: Search for any usage of `github.com/Microsoft/go-winio`. Expect: No matches. rg --type go 'github.com/Microsoft/go-winio'Length of output: 44
Line range hint
1-12:
Verify removal ofgithub.com/gorilla/handlers.Ensure that
github.com/gorilla/handlersis no longer used in the codebase.
Line range hint
1-12:
Verify removal ofgolang.org/x/mod.Ensure that
golang.org/x/modis no longer used in the codebase.Verification successful
The dependency
golang.org/x/mod v0.17.0has been successfully removed and is no longer used in the codebase.
- No references to
golang.org/x/modwere found in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if `golang.org/x/mod` is no longer used in the codebase. # Test: Search for any usage of `golang.org/x/mod`. Expect: No matches. rg --type go 'golang.org/x/mod'Length of output: 31
Script:
#!/bin/bash # Description: Verify if `golang.org/x/mod` is no longer used in the codebase. # Test: Search for any usage of `golang.org/x/mod`. Expect: No matches. rg 'golang.org/x/mod' --type go # Test: Search for any import statements of `golang.org/x/mod`. Expect: No matches. rg 'import "golang.org/x/mod' --type goLength of output: 73
Line range hint
1-12:
Verify removal ofgithub.com/DataDog/datadog-go.Ensure that
github.com/DataDog/datadog-gois no longer used in the codebase.Verification successful
Verify removal of
github.com/DataDog/datadog-go.The dependency
github.com/DataDog/datadog-gohas been successfully removed and is no longer used in the codebase.
- No matches were found for
github.com/DataDog/datadog-goin the Go files.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if `github.com/DataDog/datadog-go` is no longer used in the codebase. # Test: Search for any usage of `github.com/DataDog/datadog-go`. Expect: No matches. rg --type go 'github.com/DataDog/datadog-go'Length of output: 44
Script:
#!/bin/bash # Description: Verify if `github.com/DataDog/datadog-go` is no longer used in the codebase. # Test: Search for any usage of `github.com/DataDog/datadog-go`. Expect: No matches. rg --type go 'github.com/DataDog/datadog-go' || echo "Error during search"Length of output: 93
Script:
#!/bin/bash # Description: Verify if `github.com/DataDog/datadog-go` is no longer used in the codebase. # Check if there are any Go files in the repository if ! fd --type f --extension go; then echo "No Go files found in the repository." exit 1 fi # Test: Search for any usage of `github.com/DataDog/datadog-go`. Expect: No matches. rg --type go 'github.com/DataDog/datadog-go' || echo "Error during search"Length of output: 85707
Script:
#!/bin/bash # Description: Verify if `github.com/DataDog/datadog-go` is no longer used in the codebase. # Test: Search for any usage of `github.com/DataDog/datadog-go`. Expect: No matches. grep -r 'github.com/DataDog/datadog-go' --include \*.go . || echo "No usage found"Length of output: 97
Line range hint
1-12:
Verify removal ofgolang.org/x/tools.Ensure that
golang.org/x/toolsis no longer used in the codebase.
(cherry picked from commit 1f0ce2f)
Description
Breaking change to existing Sims in modules
*baseapp.BaseAppwithsimtypes.AppEntrypointinterface:with
MsgSimulatorFnin favour ofMsgSimulatorFnXintypes/simulationAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Bug Fixes
Chores