-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(x/authz): update changelog to include API breaking events change #21522
Conversation
WalkthroughWalkthroughThe Cosmos SDK's authorization module has undergone significant updates, including modifications to the Changes
Sequence Diagram(s)sequenceDiagram
participant App as Application
participant Keeper as Authorization Keeper
participant Router as Message Router
participant Event as Event System
App->>Keeper: NewKeeper()
Keeper->>App: Initialize with Environment
App->>Router: Set message routing
App->>Keeper: Exec(message)
Keeper->>Event: Emit event (no duplicates)
Event->>App: Notify event listeners
Tip We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
x/authz/CHANGELOG.md (1)
47-47
: Fix the grammar in the changelog entry.The static analysis tool suggests using "an" instead of "a" before "authz_msg_index".
Apply this diff to fix the grammar:
- * `Exec` no longer emits duplicate events containing a "authz_msg_index" attribute. + * `Exec` no longer emits duplicate events containing an "authz_msg_index" attribute.Tools
LanguageTool
[misspelling] ~47-~47: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...onger emits duplicate events containing a "authz_msg_index" attribute. * [#19490]...(EN_A_VS_AN)
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- x/authz/CHANGELOG.md (1 hunks)
Additional context used
Path-based instructions (1)
x/authz/CHANGELOG.md (1)
Pattern
**/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
LanguageTool
x/authz/CHANGELOG.md
[misspelling] ~47-~47: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...onger emits duplicate events containing a "authz_msg_index" attribute. * [#19490]...(EN_A_VS_AN)
Description
Noting a "soft" API break around events which was surfaced in audits.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
appmodule.Environment
for better integration with application services.DequeueAndDeleteExpiredGrants
for optimized resource management.Bug Fixes
Exec
function for clearer event handling.Documentation