chore: prepare core 1.0.0-alpha.1 #21564
Conversation
WalkthroughWalkthroughThe recent changes introduce version Changes
Sequence Diagram(s)sequenceDiagram
participant Module
participant AminoRegistrar
participant InterfaceRegistrar
participant KVStore
Module->>AminoRegistrar: Register types
AminoRegistrar-->>Module: Types registered
Module->>InterfaceRegistrar: Interact with interface
InterfaceRegistrar-->>Module: Interface interaction successful
Module->>KVStore: Use Iterator
KVStore-->>Module: Key-value interaction
Possibly related issues
Possibly related PRs
Suggested labels
Tip New featuresWalkthrough comment now includes:
Notes:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- core/CHANGELOG.md (2 hunks)
Additional context used
Path-based instructions (1)
core/CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
Additional comments not posted (1)
core/CHANGELOG.md (1)
Line range hint
39-63: Review of Changelog EntriesThe changelog entries from lines 39 to 63 are well-structured and follow the guiding principles outlined at the beginning of the file. Each entry is linked to a specific GitHub issue or pull request, which is good practice for traceability. Here are some specific observations and suggestions:
Versioning and Links:
- The version tag
[v1.0.0-alpha.1]is correctly formatted and linked. This ensures users can easily access the release notes.Features Section:
- The entries are clear and concise, each focusing on a specific change or addition. The use of GitHub issue links for each entry is consistent and helpful for further exploration.
Grammar and Spelling:
- The text is free from grammatical errors and spelling mistakes, which is crucial for professional documentation.
Content Accuracy and Completeness:
- The content aligns well with the PR summary and AI-generated summary, indicating that the changelog accurately reflects the changes made in this version.
Suggested Improvements:
- While the current format is clear, consider adding a brief description or context for each entry to enhance understanding without needing to click through to the issues.
Overall, the changelog entries are well-prepared and serve their purpose effectively.
|
moving core/store things before |
| @@ -1,3 +1,5 @@ | |||
| // Package store provides a basic API for modules to interact with kv-stores | |||
| // independently of any implementation of that functionality. | |||
| // Additionally, it provides a set of interfaces for store implementations to | |||
There was a problem hiding this comment.
I tried to move it, but I eventually didn't like that we ended up with two store packages, and this one imprting to the server one.
I'd rather extend the scope of this package instead, tbh. What do you think @aaronc?
Description
Prepares core 1.0.0-alpha.1
Closes: #21176
We still miss 1 thing before core v1 rc, namely:
In order to make easier integration, we should release an alpha ASAP.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
Summary by CodeRabbit
New Features
v1.0.0-alpha.1for the Cosmos SDK, marking a new alpha release.registry.AminoRegistrarfor improved type management in the amino codec.registry.InterfaceRegistrarto enhance modularity and extensibility.PreMsgHandlerandPostMsgHandler.MsgHandlerfor gRPC handlers.Documentation