Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump rocksdb & core & update ci codeowners #21652

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Sep 11, 2024

Description

bump cometbft-db indirect import to 0.15, and rocksdb

Bump for consistency with 0.52, due to cometbft-db 0.15.0 usage (#21598).
Bump core to alpha.2
Update codeowners for ci and scripts


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Enhanced code ownership management by assigning responsibilities for CI and build-related components.
    • Introduced server.DynamicConfig for improved configuration management flexibility.
  • Bug Fixes

    • Updated Go version from 1.23 to 1.23.1 in multiple modules, which may include bug fixes and improvements.
  • Chores

    • Upgraded the RocksDB version across various workflows, potentially enhancing performance and stability.
    • Updated several indirect dependencies in multiple modules to their latest versions, ensuring compatibility and security.
  • Style

    • Minor formatting change in the GitHub Actions workflow configuration for improved readability.

Copy link
Contributor

coderabbitai bot commented Sep 11, 2024

Walkthrough

Walkthrough

The pull request includes updates to GitHub Actions workflow files, Go module files, and introduces a new .github/CODEOWNERS file. Key changes involve upgrading the environment variable ROCKSDB_VERSION from 8.11.3 to 9.6.1 in the workflow files, incrementing the Go version from 1.23 to 1.23.1, and updating several indirect dependencies. Additionally, the new CODEOWNERS file assigns ownership for various directories and files related to continuous integration and build processes.

Changes

Files Change Summary
.github/workflows/build.yml, .github/workflows/lint.yml, .github/workflows/test.yml Updated ROCKSDB_VERSION from 8.11.3 to 9.6.1. Minor formatting change in test.yml.
client/v2/go.mod, go.mod, server/v2/cometbft/go.mod, simapp/go.mod, simapp/v2/go.mod, tests/go.mod, x/accounts/defaults/lockup/go.mod, x/accounts/defaults/multisig/go.mod, x/accounts/go.mod, x/authz/go.mod, x/bank/go.mod, x/circuit/go.mod, x/consensus/go.mod, x/distribution/go.mod, x/epochs/go.mod, x/evidence/go.mod, x/feegrant/go.mod, x/gov/go.mod, x/group/go.mod, x/mint/go.mod, x/nft/go.mod, x/params/go.mod, x/protocolpool/go.mod Updated Go version from 1.23 to 1.23.1 and various indirect dependencies to their latest versions.
.github/CODEOWNERS Added ownership for paths related to CI and build processes, assigning owners @auricom, @julienrbrt, and @tac0turtle.

Possibly related PRs

  • ci: remove nix from gh workflows #21572: This PR modifies the .github/workflows/build.yml and .github/workflows/lint.yml files to include the ROCKSDB_VERSION environment variable, which is directly related to the changes in the main PR that also updates the ROCKSDB_VERSION in these workflow files.
  • build(deps): bump to core v1.0.0-alpha.1 and remove replaces #21603: This PR updates the go.mod files to use the new core version v1.0.0-alpha.1, which may be relevant as it could affect the dependencies related to the CI and build processes mentioned in the main PR.
  • refactor(store/v2): human readable ss/sc types #21645: This PR introduces support for RocksDB in the Cosmos SDK, which is directly related to the changes in the main PR that involve managing RocksDB versions and configurations.
  • ci: rocksdb version in makefile #21654: This PR introduces a script to dynamically retrieve the ROCKSDB_VERSION from a Makefile, which aligns with the main PR's focus on managing the ROCKSDB_VERSION in the workflow files.

Suggested labels

C:Store, backport/v0.52.x


Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bcfbc40 and a66222d.

Files ignored due to path filters (27)
  • client/v2/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
  • runtime/v2/go.sum is excluded by !**/*.sum
  • server/v2/cometbft/go.sum is excluded by !**/*.sum
  • simapp/go.sum is excluded by !**/*.sum
  • simapp/v2/go.sum is excluded by !**/*.sum
  • tests/go.sum is excluded by !**/*.sum
  • x/accounts/defaults/lockup/go.sum is excluded by !**/*.sum
  • x/accounts/defaults/multisig/go.sum is excluded by !**/*.sum
  • x/accounts/go.sum is excluded by !**/*.sum
  • x/authz/go.sum is excluded by !**/*.sum
  • x/bank/go.sum is excluded by !**/*.sum
  • x/circuit/go.sum is excluded by !**/*.sum
  • x/consensus/go.sum is excluded by !**/*.sum
  • x/distribution/go.sum is excluded by !**/*.sum
  • x/epochs/go.sum is excluded by !**/*.sum
  • x/evidence/go.sum is excluded by !**/*.sum
  • x/feegrant/go.sum is excluded by !**/*.sum
  • x/gov/go.sum is excluded by !**/*.sum
  • x/group/go.sum is excluded by !**/*.sum
  • x/mint/go.sum is excluded by !**/*.sum
  • x/nft/go.sum is excluded by !**/*.sum
  • x/params/go.sum is excluded by !**/*.sum
  • x/protocolpool/go.sum is excluded by !**/*.sum
  • x/slashing/go.sum is excluded by !**/*.sum
  • x/staking/go.sum is excluded by !**/*.sum
  • x/upgrade/go.sum is excluded by !**/*.sum
Files selected for processing (28)
  • client/v2/go.mod (5 hunks)
  • core/CHANGELOG.md (1 hunks)
  • go.mod (5 hunks)
  • runtime/v2/go.mod (0 hunks)
  • server/v2/cometbft/go.mod (6 hunks)
  • simapp/go.mod (6 hunks)
  • simapp/v2/go.mod (6 hunks)
  • tests/go.mod (6 hunks)
  • x/accounts/defaults/lockup/go.mod (5 hunks)
  • x/accounts/defaults/multisig/go.mod (5 hunks)
  • x/accounts/go.mod (5 hunks)
  • x/authz/go.mod (5 hunks)
  • x/bank/go.mod (5 hunks)
  • x/circuit/go.mod (5 hunks)
  • x/consensus/go.mod (5 hunks)
  • x/distribution/go.mod (5 hunks)
  • x/epochs/go.mod (5 hunks)
  • x/evidence/go.mod (5 hunks)
  • x/feegrant/go.mod (5 hunks)
  • x/gov/go.mod (5 hunks)
  • x/group/go.mod (6 hunks)
  • x/mint/go.mod (5 hunks)
  • x/nft/go.mod (5 hunks)
  • x/params/go.mod (5 hunks)
  • x/protocolpool/go.mod (5 hunks)
  • x/slashing/go.mod (5 hunks)
  • x/staking/go.mod (6 hunks)
  • x/upgrade/go.mod (6 hunks)
Files not reviewed due to no reviewable changes (1)
  • runtime/v2/go.mod
Files skipped from review due to trivial changes (6)
  • go.mod
  • server/v2/cometbft/go.mod
  • simapp/v2/go.mod
  • x/accounts/defaults/multisig/go.mod
  • x/authz/go.mod
  • x/feegrant/go.mod
Files skipped from review as they are similar to previous changes (20)
  • client/v2/go.mod
  • simapp/go.mod
  • tests/go.mod
  • x/accounts/defaults/lockup/go.mod
  • x/accounts/go.mod
  • x/bank/go.mod
  • x/circuit/go.mod
  • x/consensus/go.mod
  • x/distribution/go.mod
  • x/epochs/go.mod
  • x/evidence/go.mod
  • x/gov/go.mod
  • x/group/go.mod
  • x/mint/go.mod
  • x/nft/go.mod
  • x/params/go.mod
  • x/protocolpool/go.mod
  • x/slashing/go.mod
  • x/staking/go.mod
  • x/upgrade/go.mod
Additional context used
Path-based instructions (1)
core/CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

Additional comments not posted (2)
core/CHANGELOG.md (2)

40-41: LGTM!

The new release version is correctly added to the changelog and linked to the GitHub tag.


42-44: LGTM!

The new feature is documented correctly in the changelog, with a clear description and a link to the relevant pull request.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@julienrbrt julienrbrt requested a review from auricom September 11, 2024 10:59
@julienrbrt julienrbrt changed the title build(deps): bump rocksdb build(deps): bump rocksdb & core & update ci codeowners Sep 12, 2024
@julienrbrt julienrbrt added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 17bd18b Sep 12, 2024
93 of 94 checks passed
@julienrbrt julienrbrt deleted the julien/rocksdb branch September 12, 2024 09:08
alpe added a commit that referenced this pull request Sep 12, 2024
* main:
  refactor(server/v2/cometbft): use only protov1 and backport #21084 (#21681)
  chore(x/staking): revert proto breakage (#21666)
  build(deps): bump rocksdb & core & update ci codeowners (#21652)
@coderabbitai coderabbitai bot mentioned this pull request Dec 2, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants