Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation regarding environment variables #2171

Merged
merged 1 commit into from
Aug 30, 2018

Conversation

mslipper
Copy link
Contributor

Closes #1973.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mslipper mslipper requested a review from zramsay as a code owner August 28, 2018 08:30
@codecov
Copy link

codecov bot commented Aug 28, 2018

Codecov Report

Merging #2171 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2171   +/-   ##
========================================
  Coverage    63.91%   63.91%           
========================================
  Files          134      134           
  Lines         8194     8194           
========================================
  Hits          5237     5237           
  Misses        2604     2604           
  Partials       353      353

@alexanderbez
Copy link
Contributor

Looks like this was already addressed in #2170. Should not have it in two PRs I think.

@mslipper
Copy link
Contributor Author

@alexanderbez I will remove from the other PR.

@jackzampolin jackzampolin self-assigned this Aug 30, 2018
@ValarDragon ValarDragon mentioned this pull request Aug 30, 2018
5 tasks
Copy link
Contributor

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a comment on the other PR to remove it from there.

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit 153756b into cosmos:develop Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants