fix(store/v2): error info maybe covered by err = batch.Close()

[lfz941]

Description

err would be nil if batch.Close() returns nil, thus the error returned by others operation would be covered.

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling logic to ensure the most relevant error is reported during batch operations, enhancing robustness and debugging capabilities.

[coderabbitai]

Walkthrough

Walkthrough

The changes introduce a modification in the error handling logic of the flushRemovedStoreKeys function within the MetadataStore class. The update involves the introduction of an additional variable to capture errors from the batch.Close() method, ensuring that the first encountered error is preserved if multiple errors occur during execution.

Changes

Files	Change Summary
store/v2/commitment/metadata.go	Modified error handling in flushRemovedStoreKeys to capture and preserve the first encountered error during batch closure.

Sequence Diagram(s)

sequenceDiagram
    participant MetadataStore
    participant Batch

    MetadataStore->>Batch: Close()
    alt Error occurs
        Batch-->>MetadataStore: Return error (cErr)
        MetadataStore->>MetadataStore: Check if err is nil
        MetadataStore->>MetadataStore: Assign cErr to err if nil
    else No error
        Batch-->>MetadataStore: Success
    end

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[julienrbrt]

Mmmh: https://github.com/cosmos/cosmos-sdk/actions/runs/10898784146/job/30242740286?pr=21727