fix(server/v2/store): fix store server flags

[julienrbrt]

Description

Add missing prefixes on store flags.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features

  • Introduced a new function for better organization of configuration flags.
  • Added a centralized server name definition for improved maintainability.

• Improvements

  • Enhanced readability and maintainability by using constants instead of hardcoded strings for flag definitions and database type retrieval.
  • Improved type safety and integration of the StoreComponent with the broader server framework.

• Bug Fixes

  • Corrected potential errors related to hardcoded strings in flag management.

[coderabbitai]

Walkthrough

Walkthrough

The changes in this pull request focus on improving code readability and maintainability in the store package. Key modifications include replacing hardcoded string literals with constants, introducing a prefix function for flag management, and enhancing type assertions for the StoreComponent. Additionally, a new constant for the server name is defined, centralizing its usage and ensuring consistency across the codebase.

Changes

File(s)	Change Summary
server/v2/store/commands.go	Replaced hardcoded string "store.app-db-backend" with constant FlagAppDBBackend in createRootStore function for improved readability.
server/v2/store/flags.go	Introduced prefix function for flag constants; modified FlagAppDBBackend, FlagKeepRecent, and FlagInterval to use this function instead of hardcoded strings.
server/v2/store/server.go	Added type assertions for StoreComponent to implement specific interfaces; defined constant ServerName to replace hardcoded string in Name() method for better maintainability.

Possibly related PRs

• refactor(store/v2): human readable ss/sc types #21645: The changes in this PR involve modifications to the store package, which is directly related to the changes made in the main PR regarding flag constants and their management in the store module.

Suggested labels

C:Store, C:server/v2

---

Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c0eced8 and 5360700.

Files selected for processing (3)

• server/v2/store/commands.go (1 hunks)
• server/v2/store/flags.go (1 hunks)
• server/v2/store/server.go (2 hunks)

Files skipped from review due to trivial changes (1)

• server/v2/store/commands.go

Additional context used

Path-based instructions (2)

server/v2/store/flags.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

server/v2/store/server.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (8)

server/v2/store/flags.go (4)

8-10: LGTM!

The prefix function is a good addition to improve the readability and avoid naming conflicts of the flags. The implementation is simple and effective.

---

13-13: LGTM!

The FlagAppDBBackend variable is now assigned the value returned by the prefix function, which is a good practice to avoid naming conflicts and to make the flags more readable.

---

14-14: LGTM!

The FlagKeepRecent variable is now assigned the value returned by the prefix function, which is a good practice to avoid naming conflicts and to make the flags more readable.

---

15-15: LGTM!

The FlagInterval variable is now assigned the value returned by the prefix function, which is a good practice to avoid naming conflicts and to make the flags more readable.

server/v2/store/server.go (4)

14-18: LGTM!

The type assertions ensure that StoreComponent implements the necessary interfaces, which improves type safety and integration with the server framework.

---

20-20: LGTM!

Defining the ServerName constant improves maintainability by centralizing the server name definition.

---

46-46: LGTM!

Returning the value of ServerName in the Name() method ensures consistency and improves maintainability.

---

Line range hint 1-80: Code conforms to the Uber Golang style guide.

The reviewed code adheres to the Uber Golang style guide:

• Package name is lowercase.
• Struct, method, and constant names follow the PascalCase convention.
• Imports are grouped and ordered correctly.
• File is formatted using gofmt.

No deviations from the style guide were found.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

@julienrbrt your pull request is missing a changelog!