Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bianjie/lcd implementation #2177

Closed
wants to merge 43 commits into from

Conversation

abelliumnt
Copy link

Proceed from: #2147
I just changed the source repo. The code is the same. I'm so sorry for bring troubles for all of you.

Haifeng Xi and others added 30 commits July 11, 2018 14:38
Refactor lcd code according to code reviewers
@cwgoes
Copy link
Contributor

cwgoes commented Aug 29, 2018

Thanks for the PR. Can we please split this, as possible, into separate PRs addressing individual concerns? That will help us review faster and ensure code quality.

See some background discussion at #2173 (comment).

@fedekunze
Copy link
Collaborator

@cwgoes this is the initial scope of the PR #2118 (comment):

  1. Add query store proof verification
  2. Add swagger-ui
  3. Lcd can connect to multiply full nodes and will do load balancing
  4. Support modular APIs. Currently we only support key management, token query, token send, stake query, node version query.

@cwgoes
Copy link
Contributor

cwgoes commented Aug 29, 2018

Can we break (1), (2), (3), and (4) into separate PRs? That seems like a natural separation.

Referencing also this section in CONTRIBUTING.md:

To accommodate review process we suggest that PRs are categorically broken up. Ideally each PR addresses only a single issue. Additionally, as much as possible code refactoring and cleanup should be submitted as a separate PRs from bugfixes/feature-additions.

(I realize this is a pain but I think we need to start being strict about it at this stage in the development cycle especially)

@abelliumnt
Copy link
Author

abelliumnt commented Aug 30, 2018

@cwgoes
Your suggestion is very thoughtful. The current PR is too big to review. It affects more than 5 thousand lines code. Indeed, this is a big trouble for code reviewer. Thanks very much for all reviewers: @fedekunze @alexanderbez .
Next I will split this PR into several parts:

  • PR1: Proof build and verification related
  • PR2:
    Add lite-server with swagger-ui and
    Add client manager(load balancing, very small change)
    Add APIs of these modules: transaction(1 API), bank(1 API) and auth(1 API).
  • PR3: Add APIs of the rest modules: key managerment(7 APIs), staking(11 APIs)
  • PR4: Add APIs of the rest modules: slasking(2 APIs) and governance(8 APIs).
  • PR5: Update gaia-lite spec to keep it consistent with its implemenation.
    @cwgoes Do you think this is reasonable?

@fedekunze
Copy link
Collaborator

@HaoyangLiu remember to add the prefix R4R to the title and the label ready-for-review when your PRs are done so we can review and merge it faster

@abelliumnt
Copy link
Author

@fedekunze Thanks for your advice. I have added R4R in the title of #2192 and #2199

@abelliumnt abelliumnt closed this Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants