Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x/tx): sort with oneof field name in amino-json #21782

Merged
merged 7 commits into from
Oct 11, 2024
Merged

fix(x/tx): sort with oneof field name in amino-json #21782

merged 7 commits into from
Oct 11, 2024

Commits on Sep 18, 2024

  1. fix: sort with oneof field name in amino-json 

    The Marshal operation in amino-json needs to take the oneof field name
into consideration when ordering the fields, otherwise the resulting
JSON will not be properly ordered.
    @maharifu
    maharifu committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1beb756 View commit details
    Browse the repository at this point in the history

  2. chore: add unreleased entry to changelog

    @maharifu
    maharifu committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    61ed948 View commit details
    Browse the repository at this point in the history

  3. sort JSON after marshalling

    @kocubinski @maharifu
    kocubinski authored and maharifu committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    16dc491 View commit details
    Browse the repository at this point in the history

  4. fix: amino-json custom encoders 

    Custom encoders module_account and threshold_string need to output
fields in lexicographical order.
    @maharifu
    maharifu committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    b16697e View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Merge remote-tracking branch 'upstream/main' into fix/amino_json_fiel… 

    …d_order
    @maharifu
    maharifu committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f459b74 View commit details
    Browse the repository at this point in the history

  2. chore: remove TODOs after merge

    @maharifu
    maharifu committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1b8274c View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Merge branch 'main' into fix/amino_json_field_order

    @maharifu
    maharifu authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    dbe0238 View commit details
    Browse the repository at this point in the history