chore: add releases to changelog #21831
Conversation
julienrbrt
requested review from
kocubinski,
testinginprod,
aaronc,
a team and
JulianToledano
as code owners
|
Warning Rate limit exceeded@julienrbrt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 1 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughWalkthroughThe pull request introduces several updates across various modules, including new CLI commands for enhanced debugging and account management, improvements to event clarity, and deprecations of certain methods and configurations. It also updates the changelog to reflect new versions and API breaking changes, particularly in the client and transaction modules, highlighting significant adjustments to how address codecs and JSON encoding are handled. Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
client/v2/CHANGELOG.md (1)
46-49: Improve readability by adding a comma.The new "API Breaking Changes" section and the description of the breaking change are clear and well-written.
To improve readability, consider adding a comma after "Instead":
- Instead client/v2 uses the address codecs present in the context + Instead, client/v2 uses the address codecs present in the contextTools
LanguageTool
[uncategorized] ~48-~48: A comma may be missing after the conjunctive/linking adverb ‘Instead’.
Context: ...autocli.AppOptionsandflag.Builder`. Instead client/v2 uses the address codecs prese...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (3)
- CHANGELOG.md (2 hunks)
- client/v2/CHANGELOG.md (1 hunks)
- x/tx/CHANGELOG.md (1 hunks)
Additional context used
Path-based instructions (3)
CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"client/v2/CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"x/tx/CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
LanguageTool
client/v2/CHANGELOG.md
[uncategorized] ~48-~48: A comma may be missing after the conjunctive/linking adverb ‘Instead’.
Context: ...autocli.AppOptionsandflag.Builder`. Instead client/v2 uses the address codecs prese...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
Additional comments not posted (11)
client/v2/CHANGELOG.md (2)
50-51: Verify the release date for v2.0.0-beta.5.The addition of the new version section for v2.0.0-beta.5 looks good.
However, please double-check the release date. 2024-09-18 seems to be in the future. Is this intentional or a typo?
56-56: Verify the release date for v2.0.0-beta.4.Referencing the previous version v2.0.0-beta.4 in the changelog provides good context.
However, similar to the v2.0.0-beta.5 release date, the date for v2.0.0-beta.4 (2024-07-16) also seems to be in the future. Please double-check if this is intentional or a typo.
x/tx/CHANGELOG.md (2)
36-40: LGTM!The new release entry is well-formatted and includes a clear description of the improvement along with a reference to the relevant pull request.
42-46: LGTM!The clarification about using
sync.Mapfor concurrent writes in thegetSignersFuncsmap and the reminder to call Validate when creating the Context are valuable additions to the changelog entry.CHANGELOG.md (7)
240-247: Changes look good!The new CLI commands and collection value additions are clearly described and seem useful. I don't see any issues with these changes.
248-253: Improvements look good!The added event attribute, improved error messages, and enhanced testability all seem like worthwhile improvements. I don't see any downsides to these changes.
Line range hint
254-261: Changes look good!The new method, event attribute, and migration handler all seem like useful additions that extend functionality in reasonable ways. The
MigrateHandlerlays good groundwork for future migration capabilities. I don't see any issues with these changes.
Line range hint
263-266: Bug fix looks good!Correcting the
db_backendconfig lookup fallback is a straightforward fix worth including in the release. I don't see any issues with this change.
Line range hint
268-283: Changes look good!The new features like custom max gas and
simd pruneUX improvement are nice additions. The bug fixes for event querying, nil account panics, snapshotter errors, and the account address cache disabling option all improve the robustness and flexibility of the system. The CometBFT version bump also helps keep things up-to-date. Overall this looks like a solid set of changes for the release.
Line range hint
285-309: Changes look excellent!This release packs in a lot of great new functionality with the snapshot features, circuit breaker, new events and commands, and the
BaseAppcleanup method. The various improvements to the store, simulation, and error handling are also very useful.Fixing the security vulnerability and address validation issue is crucial. The CometBFT version bump and IAVL fix also help keep things running smoothly.
Overall this looks like a significant and valuable set of changes for the release. Great work!
Line range hint
311-325: Changes look solid!The
GetAllVersionsaddition to the app store and the evidence decoding support in the codec are handy new capabilities to have.The various fixes for gRPC reflection, consensus params in begin/end blockers, and
LegacyAminoPubKeyJSON decoding are important corrections that improve the reliability of the system.The debug error messages are a nice quality-of-life improvement for developers troubleshooting issues.
Overall this set of changes, while relatively small, makes meaningful improvements. Looks good to me!
Description
Add changelogs to main
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
module-hash-by-heightandbulk-add-genesis-accountcommands in the CLI for enhanced functionality.LegacyDeccollection value in the types/collections module.MsgMultiSendevent with a newSenderattribute.Improvements
typefield as a proto message URL in queries.Bug Fixes
Version Updates