Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: x/accounts systemtests (backport #22320) #22338

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 23, 2024

Description

Closes: #21954


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Introduced a new test for account migration, enhancing coverage of account functionalities.
    • Added a method to retrieve public keys based on custom fields in the CLI.
    • Expanded dependency injection capabilities for account management in the command execution.
  • Bug Fixes

    • Improved clarity and robustness in account initialization and migration processes.
    • Enhanced error handling for account-related operations.
  • Documentation

    • Updated method signatures for better understanding and usage in the account module.

This is an automatic backport of pull request #22320 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner October 23, 2024 05:09
@sontrinh16
Copy link
Member

hmmm system test is failling for real i think

@sontrinh16
Copy link
Member

hmmm system test is failling for real i think

strange, works on my local machine

@julienrbrt
Copy link
Member

hmmm system test is failling for real i think

strange, works on my local machine

yes, it's chain upgrade (TestChainUpgrade) which is tracked here: #22146

@julienrbrt julienrbrt merged commit 1d727a3 into release/v0.52.x Oct 23, 2024
72 of 74 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.52.x/pr-22320 branch October 23, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants