Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(indexer): implement schema.HasModuleCodec interface in the bank module #22349

Merged
merged 4 commits into from
Oct 30, 2024
Merged

feat(indexer): implement schema.HasModuleCodec interface in the bank module #22349

merged 4 commits into from
Oct 30, 2024

Conversation

cool-develope
Copy link
Contributor

@cool-develope cool-develope commented Oct 23, 2024 •
edited by coderabbitai bot
Loading

Description

ref: #20352

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features
    • Introduced a new method for enhanced module codec handling, improving data decoding processes.
  • Improvements
    • Enhanced clarity of key names in various collections, aiding in better data management.
  • Dependency Updates
    • Updated module requirements for improved compatibility and functionality.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2024 •
edited
Loading

Caution

Review failed

The head commit changed during the review from b7accc7 to 82a8d7e.

📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes in this pull request primarily focus on enhancing the BaseViewKeeper implementation in the keeper/view.go file. A new method, ModuleCodec, is introduced to implement the schema.HasModuleCodec interface, facilitating the decoding of module KVPairUpdate. Additionally, modifications are made to the initialization of collections.Map and collections.IndexedMap instances, improving the clarity of key names and introducing NamedPairKeyCodec for the Balances map.

Changes

File Change Summary
x/bank/keeper/view.go - Added method ModuleCodec to BaseViewKeeper struct.
- Updated initialization of collections.Map and collections.IndexedMap in NewBaseViewKeeper.
- Introduced NamedPairKeyCodec for the Balances map.

Possibly related PRs

  • feat(server/v2): init the indexer in server/v2 #22218: The changes in this PR involve the introduction of new methods and configurations related to indexing, which may interact with the ModuleCodec functionality added in the main PR, particularly in how data is handled and decoded within the application.

Suggested labels

C:x/bank, C:schema

Suggested reviewers

  • tac0turtle
  • akhilkumarpilli
  • sontrinh16
  • julienrbrt
  • kocubinski

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
Contributor

@cool-develope your pull request is missing a changelog!

@julienrbrt julienrbrt added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Oct 23, 2024
@octavio12345300
Copy link

😁

@octavio12345300
Copy link

😁

julienrbrt
julienrbrt approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@julienrbrt
Copy link
Member

Can you run go mod tidy?

aaronc
aaronc approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start. We will need to add HasSchemaCodec implementations for each of the codecs in follow ups. Right now they will probably end up with the default JSONB column type in Postgres which isn't ideal.

@cool-develope cool-develope added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 6b6e715 Oct 30, 2024
72 of 73 checks passed
@cool-develope cool-develope deleted the indexer/int_bank branch October 30, 2024 13:19
mergify bot pushed a commit that referenced this pull request Oct 30, 2024
@cool-develope @mergify
feat(indexer): implement schema.HasModuleCodec interface in the `ba…
86109f6 
…nk` module (#22349)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
(cherry picked from commit 6b6e715)

# Conflicts:
#	x/bank/go.mod
#	x/bank/keeper/view.go
@mergify mergify bot mentioned this pull request Oct 30, 2024
Merged
12 tasks
julienrbrt pushed a commit that referenced this pull request Nov 4, 2024
@mergify @cool-develope @tac0turtle
feat(indexer): implement schema.HasModuleCodec interface in the `ba…
878e306 
…nk` module (backport #22349) (#22398)

Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
@coderabbitai coderabbitai bot mentioned this pull request Nov 4, 2024
Merged
12 tasks
alpe added a commit that referenced this pull request Nov 6, 2024
@alpe
Merge branch 'main' into alex/sam/dec-type
711deef 
* main: (24 commits)
  build(deps): upgrade to iavl@v1.3.1 (#22436)
  docs: Update tendermint validators query pagination documentation (#22412)
  refactor(client/v2): offchain uses client/v2/factory (#22344)
  feat: wire new handlers to grpc (#22333)
  fix(x/group): proper address rendering in error (#22425)
  refactor(serevr/v2/cometbft): update `RegisterQueryHandlers` and GRPC queries (#22403)
  docs: update ADR 59 (#22423)
  build(deps): Bump github.com/fsnotify/fsnotify from 1.7.0 to 1.8.0 in /tools/cosmovisor (#22407)
  docs: Module account address documentation (#22289)
  feat(baseapp): add per message telemetry (#22175)
  docs: Update Twitter Links to X in Documentation (#22408)
  docs: redirect the remote generation page (#22404)
  refactor(serverv2): remove unused interface methods, honuor context  (#22394)
  fix(server/v2): return ErrHelp (#22399)
  feat(indexer): implement `schema.HasModuleCodec` interface in the `bank` module (#22349)
  refactor(math): refactor ApproxRoot for readality (#22263)
  docs: fix KWallet Handbook (#22395)
  feat(client/v2): broadcast logic (#22282)
  refactor(server/v2): eager config loading (#22267)
  test(system): check feePayers signature (#22389)
  ...
@coderabbitai coderabbitai bot mentioned this pull request Nov 25, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octavio12345300 octavio12345300 octavio12345300 approved these changes

@sontrinh16 sontrinh16 sontrinh16 approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@aaronc aaronc aaronc approved these changes

Assignees

@aaronc aaronc

@julienrbrt julienrbrt

@sontrinh16 sontrinh16

Labels
backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release C:x/bank
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cool-develope @octavio12345300 @julienrbrt @aaronc @sontrinh16 @facundomedica