refactor(simdv2): allow non-comet server components (backport #22351) #22353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames NewRootCmd to NewCometBFTRootCmd, to make it clear that it uses CometBFT for the consensus layer. Callers who want to use a different consensus-providing server component can instead call NewRootCmdWithConsensusComponent, passing in a callback to be evaluated with a client context in order to produce the component.
This pattern is working for Gordian-Cosmos integration.
I'm not especially tied to the new function names. I'm also open to more clear naming for "consensus component" which occurs a few times.
/cc @kocubinski as this may overlap or conflict with #22267.
Summary by CodeRabbit
New Features
NewCometBFTRootCmd
function for improved consensus component integration.NewRootCmdWithConsensusComponent
function for flexible command creation.Bug Fixes
Tests
This is an automatic backport of pull request #22351 done by [Mergify](https://mergify.com).