Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genesis: Ensure no dup validators, or bonded and revoked validators #2280

Merged
merged 1 commit into from
Sep 9, 2018

Conversation

ValarDragon
Copy link
Contributor

ref #2229

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 8, 2018

Codecov Report

Merging #2280 into develop will increase coverage by 0.05%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2280      +/-   ##
===========================================
+ Coverage    63.83%   63.89%   +0.05%     
===========================================
  Files          140      140              
  Lines         8666     8680      +14     
===========================================
+ Hits          5532     5546      +14     
  Misses        2754     2754              
  Partials       380      380

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit 8b8028e into develop Sep 9, 2018
@cwgoes cwgoes deleted the dev/validate_genesis_vals branch September 9, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants