feat(indexer/postgres)!: add basic support for header, txs and events (backport #22695) #22808

mergify · 2024-12-09T18:46:23Z

Description

Related to epic #20352

Added failure message if the indexer fails on block 1, as we can't rollback from that, the user will have to reset the node before restarting, otherwise the indexer will have missed that block.
Added txDecoder to baseapp listenerWrapper, which will then be used to get the JSON of the decoded tx.
Added BlockNumber to event and TxData
Added some fixes for v2

Missing:

tx hash. For this we need to use the decoded tx's Hash method, which is not accessible from the postgres indexer side, and if we want to access it from the baseapp side then we'd need to decode it before.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

New Features
- Enhanced error handling during commit operations to prevent invalid rollbacks.
- Added support for block height information in transaction and event processing.
- Introduced new methods for handling transactions and events in the listener.
- Enhanced event handling with block-specific information for better traceability.
- Added a new method for module codec management in the accounts module.
Bug Fixes
- Improved error management in transaction decoding, allowing block finalization despite individual transaction failures.
Documentation
- Updated module dependencies and replace directives for better local development support.
Chores
- Added new dependencies for PostgreSQL support and updated existing ones for various modules.

This is an automatic backport of pull request #22695 done by [Mergify](https://mergify.com).

…#22695) (cherry picked from commit 332d0b1) # Conflicts: # go.mod # go.sum # indexer/postgres/base_sql.go # indexer/postgres/listener.go # runtime/v2/app.go # runtime/v2/go.mod # runtime/v2/go.sum # schema/appdata/data.go # schema/decoding/middleware.go # server/v2/cometbft/go.mod # server/v2/cometbft/go.sum # server/v2/go.mod # server/v2/go.sum # server/v2/stf/go.mod # server/v2/stf/go.sum # server/v2/stf/stf.go # simapp/go.mod # simapp/go.sum # simapp/v2/go.mod # simapp/v2/go.sum # tests/go.sum # x/accounts/go.mod # x/accounts/go.sum # x/distribution/go.mod # x/distribution/go.sum

mergify · 2024-12-09T18:46:24Z

Cherry-pick of 332d0b1 has failed:

On branch mergify/bp/release/v0.52.x/pr-22695
Your branch is up to date with 'origin/release/v0.52.x'.

You are currently cherry-picking commit 332d0b106.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   baseapp/abci.go
	modified:   baseapp/streaming.go
	modified:   codec/collections.go
	modified:   server/v2/cometbft/abci.go
	modified:   server/v2/cometbft/streaming.go
	modified:   simapp/v2/app_di.go
	modified:   tests/go.mod
	modified:   x/accounts/keeper.go
	modified:   x/accounts/module.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   go.mod
	both modified:   go.sum
	deleted by us:   indexer/postgres/base_sql.go
	deleted by us:   indexer/postgres/listener.go
	deleted by us:   runtime/v2/app.go
	deleted by us:   runtime/v2/go.mod
	deleted by us:   runtime/v2/go.sum
	deleted by us:   schema/appdata/data.go
	deleted by us:   schema/decoding/middleware.go
	both modified:   server/v2/cometbft/go.mod
	both modified:   server/v2/cometbft/go.sum
	deleted by us:   server/v2/go.mod
	deleted by us:   server/v2/go.sum
	deleted by us:   server/v2/stf/go.mod
	deleted by us:   server/v2/stf/go.sum
	deleted by us:   server/v2/stf/stf.go
	both modified:   simapp/go.mod
	both modified:   simapp/go.sum
	both modified:   simapp/v2/go.mod
	both modified:   simapp/v2/go.sum
	both modified:   tests/go.sum
	both modified:   x/accounts/go.mod
	both modified:   x/accounts/go.sum
	both modified:   x/distribution/go.mod
	both modified:   x/distribution/go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

coderabbitai · 2024-12-09T18:46:30Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-12-09T18:46:41Z

@mergify[bot] your pull request is missing a changelog!

github-actions · 2024-12-09T18:47:15Z

baseapp/abci.go

 				app.logger.Error("Commit listening hook failed", "height", blockHeight, "err", err)
 				if app.streamingManager.StopNodeOnErr {
 					err = fmt.Errorf("Commit listening hook failed: %w", err)
+					if blockHeight == 1 {
+						// can't rollback to height 0, so just return the error
+						return nil, fmt.Errorf("failed to commit block 1, can't automatically rollback: %w", err)
+					}


Change potentially affects state.

Call sequence:

(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).Commit (baseapp/abci.go:972)

mergify bot requested a review from a team as a code owner December 9, 2024 18:46

mergify bot added the conflicts label Dec 9, 2024

github-actions bot added C:x/distribution distribution module related C:server/v2 Issues related to server/v2 C:x/accounts C:schema C:indexer/postgres C:server/v2 stf C:server/v2 cometbft labels Dec 9, 2024

github-actions bot reviewed Dec 9, 2024

View reviewed changes

julienrbrt added 2 commits December 9, 2024 20:31

conflicts

93965ae

ops

8ddd4b9

julienrbrt approved these changes Dec 9, 2024

View reviewed changes

julienrbrt removed the conflicts label Dec 9, 2024

github-actions bot added C:x/staking C:CLI C:x/gov C:x/slashing C:x/mint C:x/bank C:x/params C:x/evidence C:x/upgrade and removed C:schema C:indexer/postgres C:server/v2 stf labels Dec 9, 2024

github-actions bot added C:x/feegrant C:x/authz C:x/group C:x/nft C:x/consensus C:x/circuit C:x/protocolpool C:x/epochs C:x/accounts/lockup C:x/accounts/multisig C:x/accounts/base labels Dec 9, 2024

julienrbrt merged commit 9ec294a into release/v0.52.x Dec 9, 2024
79 of 81 checks passed

julienrbrt deleted the mergify/bp/release/v0.52.x/pr-22695 branch December 9, 2024 20:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(indexer/postgres)!: add basic support for header, txs and events (backport #22695) #22808

feat(indexer/postgres)!: add basic support for header, txs and events (backport #22695) #22808

mergify bot commented Dec 9, 2024

mergify bot commented Dec 9, 2024

coderabbitai bot commented Dec 9, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot commented Dec 9, 2024

github-actions bot Dec 9, 2024

feat(indexer/postgres)!: add basic support for header, txs and events (backport #22695) #22808

feat(indexer/postgres)!: add basic support for header, txs and events (backport #22695) #22808

Conversation

mergify bot commented Dec 9, 2024

Description

Author Checklist

Reviewers Checklist

Summary by CodeRabbit

mergify bot commented Dec 9, 2024

coderabbitai bot commented Dec 9, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot commented Dec 9, 2024

github-actions bot Dec 9, 2024

Choose a reason for hiding this comment